[D8] Astrology

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectastrologygit

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi chandu,

I found some issue on your module on PAreview. Plesae fix it.

https://pareview.sh/node/2655

Hi chandu7929,

I have been reviewing your module and found that you have used depreciated db_queries in your codebase instead we should use dependency injection for database connection.

$query = db_select('astrology_signs', 'as_')
      ->fields('as_')
      ->condition('name', $sign_name, '=')
      ->condition('astrology_id ', $astrology_id, '=')
      ->execute();

Please do not assign this issue to yourself. Then it looks like changes are in progress.

Hi @chandu7929,

i am able to see some error in Pareview of your project.
Pareview reports some new warnings:

. The headings in the readme file should be uppercase.
. The module does not implement hook_help().

https://pareview.sh/pareview/https-git.drupal.org-project-astrology.git

Hi @chandu7929,

i am able to see some error of automated PAreview in this 8.x-1.x branch.

https://pareview.sh/pareview/https-git.drupal.org-project-astrology.git-...

Automated Review

Review of the 8.x-1.x branch (commit 7d82972):

• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

no issues

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.