[D8] Taxonomy Import

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,

Please do check automated review of your module.

Review of the 8.x-1.x branch (commit a933b71):

• Remove all backup files from your repository:
  

  ./taxonomy_import.info.yml~
  

• ./src/Form/ImportForm.php: all functions should be prefixed with your module/theme name to avoid name clashes. See https://www.drupal.org/node/318#naming
  

  function create_taxonomy($voc_name) {
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/taxonomy_import.install
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
  9 | ERROR | [x] Whitespace found at end of line
 10 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Controller/ImporttaxonomyController.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------
  8 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  9 | ERROR   | [ ] Doc comment short description must be on a single
    |         |     line, further text should be a separate paragraph
 11 | ERROR   | [x] Whitespace found at end of line
 12 | ERROR   | [x] Missing class doc comment
 19 | ERROR   | [x] There must be no blank lines after the function
    |         |     comment
 20 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: /root/repos/pareviewsh/pareview_temp/src/Form/ImportForm.php
--------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------
  13 | ERROR | [x] Whitespace found at end of line
  14 | ERROR | [x] Missing class doc comment
  20 | ERROR | [x] You must use "/**" style comments for a function
     |       |     comment
  55 | ERROR | [x] Whitespace found at end of line
  99 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
     |       |     but found 2 spaces
  99 | ERROR | [x] Expected one space after the comma, 0 found
  99 | ERROR | [x] Expected one space after the comma, 0 found
 101 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements
 103 | ERROR | [x] Namespaced classes/interfaces/traits should be
     |       |     referenced with use statements
 117 | ERROR | [x] Expected 1 space after "="; 0 found
 122 | ERROR | [x] Whitespace found at end of line
 134 | ERROR | [x] Expected 1 space after "="; 0 found
 182 | ERROR | [x] Expected 1 space before ">="; 0 found
 182 | ERROR | [x] Expected 1 space after ">="; 0 found
 195 | ERROR | [x] Whitespace found at end of line
 198 | ERROR | [x] Expected 1 space after "="; 0 found
 211 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: /root/repos/pareviewsh/pareview_temp/css/style.css
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 2 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /root/repos/pareviewsh/pareview_temp/taxonomy_import.module
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
  4 | ERROR | [x] The second line in the file doc comment must be "@file"
  5 | ERROR | [x] Whitespace found at end of line
  7 | ERROR | [x] Whitespace found at end of line
  8 | ERROR | [x] Additional blank lines found at end of doc comment
  8 | ERROR | [x] There must be no blank lines after the function comment
  9 | ERROR | [x] Whitespace found at end of line
 13 | ERROR | [x] No space found before comment text; expected "// For
    |       |     custom form" but found "//For custom form"
 13 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 101ms; Memory: 8Mb

We have fixed the coding standard issues and updated.

@neethups : Coding standard is good.

Manual Review :

Help link was missing for getting sample file in configuration form. For that, I have created patch in project listing. Please do check : https://www.drupal.org/node/2892261

I have reviewed your code. I found, you have used following code for getting uploaded file.

$loc = db_query('SELECT file_managed.uri FROM file_managed ORDER BY file_managed.fid DESC limit 1', []);
  foreach ($loc as $val) {
    // Get location of the file.
    $location = $val->uri;
  }

It will create issue if multiple users will upload files at same time.

As well as, after uninstalling this module, it is not removing files which I have uploaded from site/default/files/taxonomy_files directory.

@rigider : Thanks for the patch.
Issues are fixed and updated.

It looks good

Thank you for your contribution!

We just accept applications from users who don't have the vetted role. Any application opened after the role is given is closed settings its status to Closed (duplicate) (if a previous application exists) or Closed (won't fix) (if a previous application cannot be found in this issue queue).
The purpose of these applications is not reviewing every project, but give users the vetted role. Once the role is given, the users will be able to change the status of their projects (the ones they already created, or the ones they will create).