Link Autocomplete content type filter

let's try this reroll against 8.4.x

Your patch worked for me, however it has an error: invalid argument supplied for foreach() when you haven't chosen any of the checkboxes yet.

I'll submit a patch that fixes that.

It would be great to get this in core. I have a lot of content types and most of them I don't want to show up as potential links.

Rerolling for 8.5.x.

The patch applies cleanly and works as expected. Does this need test coverage to make it into core?

Re-rolled patch for 8.6.x and added validation of optional content type within LinkWidget::validateUriElement.

Original patch did not include validation step for fields that make use of this new content type restriction option.

Patch re-rolled to update schema after test failure.

Re-rolled for core unit test coverage.

Updates after further failed tests.

Mislabeled interdiff.

#31 is simply a Drupal-8.5.x backport (for anyone who needs it) of #26, which is compatible with Drupal-8.6.x.

#26 should be the patch to be committed or updated going forward.

1. +++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
   @@ -142,6 +169,36 @@ public static function validateUriElement($element, FormStateInterface $form_sta
   +        foreach ($content_types as $key => $type) {
   

   I think this can be expressed as:

   $content_types = array_filter($content_types);

   That should filter out all of the non-selected content types.

2. +++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
   @@ -142,6 +169,36 @@ public static function validateUriElement($element, FormStateInterface $form_sta
   +        $entity_type = key($params);
   

   Content types = node. We always know we're going to have a node here, so we should just check for the existence of $params['node'], then explicitly use node storage.

3. +++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
   @@ -142,6 +169,36 @@ public static function validateUriElement($element, FormStateInterface $form_sta
   +          $form_state->setError($element, t('Allowed content types for internal links: @content_types', [
   

   I think this message could be clearer. What about something like "You have referenced content of a type that is not allowed here. Allowed types: @content_types."

4. +++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
   @@ -196,6 +253,31 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
   +        foreach ($content_types as $key => $type) {
   

   You can use array_filter() here too.

Re-rolled patch for 8.6.x and 8.5.x based on comments in #32. Thanks @rbayliss!

Regarding the second proposed change in #32: Because of the ongoing work in https://www.drupal.org/node/2423093 to allow for multiple entity types within entity_autocomplete fields, I think we should try to keep our new code as generalized as possible, to allow for additional entity types in the future. I've adjusted the patch accordingly.

Updated patch to use more accurate entity_bundles name instead of content_types names for new field setting, to support future work being done in https://www.drupal.org/node/2423093.

• Updated patch with a @todo to add other entity support for internal link entity types: currently just allows for nodes.
• Added #states functionality to Link field settings forms for entity bundles.

Changed entity bundle field setting widget to use a select input instead of a checkbox.
Added human-readable entity bundle labels for error messages.

Re-rolled for 8.7.x

Re-rolled for 8.9.x

Re-rolled for 9.2.x

Hi @rahulrasgon,

Above test cases, #45 is getting failed.
Can you please check it once again and attached some before and after screenshots.

Needs to be re-rolled for 9.3.x
Can be a move to Needs work

Updated patch for 9.3.x. Please review.

Adding patch for 9.3.x

Re-rolled for 10.2.x

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Have not reviewed but issue summary doesn't follow correct template

Re-rolled for 10.3.9

I'm closing this in favor of #3373258: Allow to select reference method in link field type for internal links. Because it implements the entity reference selection plugin it inherently includes the ability to select bundles. Also, the MR in the other issue has a few advantages. It's a more complete patch. It's consistent with the way that the EntityReferenceItem class works instead of being a unique implementation. And it has tests.

Credit has been granted to everyone who worked on the patch in this issue. Thank you for your contributions!