Not all toolbar items are tabs: Toolbar's "activeTab" handling interferes with active-link.js

hook_toolbar() (see core/modules/toolbar/toolbar.api.php) speaks of toolbar items. But then core/modules/toolbar/templates/toolbar.html.twig marks every toolbar item as a tab:

Hmm.. can be improved but not a problem for most CSS guy I think. `.toolbar-tab` is a helper class for tab-like style. And for the customized site, changing the Twig markup to remove `.toolbar-tab` for LINK also makes sense. (Toolbar default to support Tab-like style only)

The patch removed the default active Tab. I'm not so sure it's a Bug or Task. (Or incomplete patch?) I don't like its default to active also but I thought the UX guy has diff thoughts...

** Note: I can see the buggy on default active tab to `$('.toolbar-bar .toolbar-tab:not(.home-toolbar-tab) a').get(0)` on frontend is a problem. But @wim's IS mixed few requests as I seen.

Triggering Bots.

- 8.5.x reroll

- Find the first item and make sure it has a tray to be opened, data-toolbar-tray.

+++ b/core/modules/toolbar/js/toolbar.es6.js
@@ -136,6 +136,19 @@
+          if (typeof attr !== typeof undefined && attr !== false) {

I was wondering: is this the only/best way to check for typeof. According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operat... the only value which returns undefined for typeof is undefed, so why can't you use attr === undefined

On top of this question, here is also a test.

- The .attr() method returns a cross browser undefined for attributes that have not been set. jQuery Docs. No more scary symbol typeof helper.
- Fix übernit.

Improvement looks good, thanks! Only two small things I found:

1. +++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
   @@ -48,4 +54,25 @@ public function testToolbarToggling() {
   +   * Tests a toolbar with the first item being only an item.
   

   Can we somehow make this more clear? An item being an item, is well, what an item is.

2. +++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
   @@ -48,4 +54,25 @@ public function testToolbarToggling() {
   +    // Ensure that there is not active tab by default.
   

   not => no

- #20.1 - I think this is more clear now?
- #20.2 - 👍🏿

Re-rolled patch againt 9.5.x. Please review

Looks like an issue with the patch

Fixing the reported prettier/prettier issue.

Looks like the patch is still having issues.

You can run core/scripts/dev/commit-code-check.sh to check the code before making the patch.

Fixed build errors of #34

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Re-rolled patch for 10.1.x, Please review

This was already rtbc in #19 and the 2 things that were requested by @Gábor Hojtsy have been fixed. Looks good to me.

I guess it's not about tour.module.

+++ b/core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php
@@ -50,6 +55,7 @@ public function testToolbarToggling() {
+    $this->createScreenshot('/tmp/foo.png');

Stray debug code in the test.

Removed the extra code as suggested in #42