Provide a URL field formatter

1. +++ b/src/Plugin/Field/FieldFormatter/VideoUrl.php
   @@ -0,0 +1,49 @@
   +class VideoUrl extends Video {
   

   Do we need to extend this?

2. +++ b/src/Plugin/Field/FieldFormatter/VideoUrl.php
   @@ -0,0 +1,49 @@
   +        $autoplay = $this->currentUser->hasPermission('never autoplay videos') ? FALSE : $this->getSetting('autoplay');
   

   Why is this relevant?

3. +++ b/src/Plugin/Field/FieldFormatter/VideoUrl.php
   @@ -0,0 +1,49 @@
   +        $embed_code = $provider->renderEmbedCode($this->getSetting('width'), $this->getSetting('height'), $autoplay);
   +        if (!empty($embed_code['#url']) && ($embed_url = Url::fromUri($embed_code['#url']))) {
   

   Why not just print $item->value? We cannot rely on #url being set, some providers might choose to return a different render array structure to render their videos.

4. +++ b/src/Plugin/Field/FieldFormatter/VideoUrl.php
   @@ -0,0 +1,49 @@
   +        $element[$delta]['#cache']['contexts'][] = 'user.permissions';
   

   I don't think this is needed.

Re: #3, what I'm saying is, the method is called renderEmbedCode, it doesn't enforce across all the providers who implement the interface that the renderable array returned will by type => video_embed_iframe, this is simply a convention the youtube/vimeo ones use currently.

The patch in #2 was outputting an incorrect url for me (https://www.youtube.com/embed/videoseries), without the video ID.

Attached patch simply outputs the $item->value, as suggested in #3, which I would expect from a 'Video URL' field formatter. Not sure if this a solid approach though (we may need to build the url in a different way).

Still NW for tests.

+1 for this, very important requirement!

+1 for this, could it also be used to provide the thumbnail URL instead of the thumbnail image?

Is this issue still alive ?
Because it would be very useful

-- Comment was incorrect sorry -- *deleted*

+1 for this as well. It seems likely that you would want to get at the video url

@brunodbo, would you be so kind to reroll your patch and check why the tests fail? It would be nice to have this RTBC'd soon.

+1

Queuing test bot.

Is the test that failed in #6 still relevant? It doesn't show up at https://www.drupal.org/node/1243930/qa anymore. In any case, I queued the patch in #6 for testing with the 'PHP 5.5 & MySQL 5.5, Drupal 8.7.x' test.

As far as I can tell from https://www.drupal.org/pift-ci-job/819115, the fail in #6 had to do with the usage of deprecated code elsewhere in the module, not related to the patch.

Well I think we can set this RTBC? patch is green now and we have good feedback!

Thank you very much for this patch. I've made a small modification to it to better support Youtube playlists. When the provider is a playlist, the url should link to the playlist page rather than to the first video in the playlist. This patch achieves that by simply changing the url from youtube.com/watch to youtube.com/playlist.

Thank you Peacog,

your patch looks good and works, but I can't get that str_replace, which seems a bit dirty to me. Can you provide a working example here? If I change watch to "playlist" in Youtube URLs, the URL is broken for me? What am I doing wrong?

Would be nice to push this forward!

Hi @Peacog,

could you perhaps provide a short example for my "str_replace" question in #18? It would be nice to move forward here, because this is a deserved feature for several users.

Hi @Anybody.

When you want to embed a playlist this module requires you to provide an url with the format https://www.youtube.com/watch?v=VIDEO_ID&list=PLAYLIST_ID, i.e. it includes the id of the first video as well as the id of the playlist itself. With urls of that format you can replace 'watch' with 'playlist'.

There is an alternative way to solve the playlist problem in #3028911: Provider does not support linking to playlist page. I haven't tried it myself but if it works it might be a better solution.

Well I think we can set this RTBC now and hope for maintainer review?

With the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.

I'd like to set this back to RTBC as this now has a 3.0.x branch, this still works perfectly and patch still applies. Can we please merge this into 3.0.x?

Could we have an MR please?

@mably thanks for the super quick reply! Yes already on it, we'll post it here tomorrow! Probably @grevil will do it and finally check the implementation.

Ok, I created the MR and made the code a bit prettier. Please review!

I am a bit unsure about the output array:

      $elements[$delta] = [
        '#markup' => $video_url->toString(),
        '#url' => $video_url,
      ];

looks a bit odd don't you think?

Note, that test failures are unrelated. The tests are simply not compatible with the newest PHPUnit version. We should fix that in a seperate issue.

Re #30 that was already part of the first patch and has been reviewed, so I think it should be fine IMHO

Please link the test issue here, once created.

Done, tests fixed here: #3554816: Fix PHPUnit tests.

Related issue has been merged.

Tests are also green here now! :)