Closed (fixed)
Project:
Feeds Tamper
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 May 2017 at 02:37 UTC
Updated:
7 Oct 2018 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sakural commentedComment #3
jackenmailHi All,
I have tested this patch and its working properly.
Thanks,
Comment #4
megachrizThis line applies to the D6 version of Feeds. Should be removed.
This applies to the D6 version of Feeds Tamper. There is no alpha3 version for Feeds Tamper 7.x-1.x.
Should be removed.
Comment #5
firfin commentedUpdated the patch from #2 according to the comments in #4. Also fixed some grammar / spelling.
Comment #7
dhruveshdtripathi commentedUpdated patch with README template (https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...)
Comment #9
firfin commentedTesting fails because CTools is using short array syntax and we are using tests with php 5.3 . Changed the php version used for testing.
Comment #10
firfin commentedComment #11
megachrizQuick review:
Missing dot at the end of the sentence.
"Your can add tampers" doesn't sound like proper English. I'm also not sure why "TAMPER" should be all caps. This should probably be rephrased a bit. Explain how to get to Tamper configuration, how adding Tampers work and that they can be rearranged.
It's probably enough to just link to the documentation.
Neither I nor Chris are currently actively maintaining the D7 version of this module (you could say though that I’m passively maintaining it). I'm mainly working on the D8 version. Not sure how to rephrase that, but "Current" seems a bit out of place.
Comment #12
nileema.jadhav commentedWorked on @dhruveshdtripathi 's patch to incorporate @MegaChriz 's comments
Comment #13
nileema.jadhav commentedComment #15
megachrizI made a few changes to the readme and committed the result.
Changes: