Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is an admin theme based on Google Material design guidelines. It is created to make the work of content managers and administrator more intuitive and pleasant and spread the use of Drupal.
Project link
https://www.drupal.org/project/agnian_material_admin
Git instructions
git clone --branch 8.x-1.x https://git.drupal.org/project/agnian_material_admin.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-agnian_materia...
Comment | File | Size | Author |
---|---|---|---|
#25 | agnian_material_admin_2875653_02012019_24.patch | 70 bytes | saidatom |
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
cchanana CreditAttribution: cchanana commentedHello ysarkisyan,
I have installed your theme and find following UI issue in Chrome and firebox browser.
1. On "admin/structure" page there is alignment issue in chrome. Please find attach screenshot for the same (
Firefox.png and chrome.png).
2. On "admin/config/system/site-information" color of text is different in both browser. Please find attach screenshot for the same (
site-information-firefox-color.png and site-information-chrome-color.png).
Comment #4
ysarkisyan CreditAttribution: ysarkisyan commentedComment #5
ysarkisyan CreditAttribution: ysarkisyan commentedComment #6
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectagnian_material_admi...
Fixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
Ravi Cmsminds CreditAttribution: Ravi Cmsminds commentedHi,
I checked your theme and found some issues and recommendations that you may be interested in :
FILE: /root/repos/pareviewsh/pareview_temp/agnian_material_admin.theme
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
18 | ERROR | [x] Inline control structures are not allowed
92 | ERROR | [x] Inline control structures are not allowed
95 | ERROR | [x] Inline control structures are not allowed
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/css/agnian.css
-----------------------------------------------------------------------
FOUND 105 ERRORS AFFECTING 54 LINES
-----------------------------------------------------------------------
29 | ERROR | [x] Multiple selectors should each be on a single line
40 | ERROR | [x] Multiple selectors should each be on a single line
51 | ERROR | [x] Multiple selectors should each be on a single line
54 | ERROR | [x] Multiple selectors should each be on a single line
57 | ERROR | [x] Multiple selectors should each be on a single line
60 | ERROR | [x] Multiple selectors should each be on a single line
63 | ERROR | [x] Multiple selectors should each be on a single line
66 | ERROR | [x] Multiple selectors should each be on a single line
69 | ERROR | [x] Multiple selectors should each be on a single line
142 | ERROR | [x] Multiple selectors should each be on a single line
142 | ERROR | [x] Multiple selectors should each be on a single line
616 | ERROR | [x] Multiple selectors should each be on a single line
616 | ERROR | [x] Multiple selectors should each be on a single line
998 | ERROR | [x] Multiple selectors should each be on a single line
1075 | ERROR | [x] Multiple selectors should each be on a single line
1133 | ERROR | [x] Multiple selectors should each be on a single line
1153 | ERROR | [x] Multiple selectors should each be on a single line
1153 | ERROR | [x] Multiple selectors should each be on a single line
1153 | ERROR | [x] Multiple selectors should each be on a single line
1153 | ERROR | [x] Multiple selectors should each be on a single line
1153 | ERROR | [x] Multiple selectors should each be on a single line
1314 | ERROR | [x] Multiple selectors should each be on a single line
1314 | ERROR | [x] Multiple selectors should each be on a single line
1361 | ERROR | [x] Multiple selectors should each be on a single line
1361 | ERROR | [x] Multiple selectors should each be on a single line
1503 | ERROR | [x] Multiple selectors should each be on a single line
1503 | ERROR | [x] Multiple selectors should each be on a single line
1510 | ERROR | [x] Multiple selectors should each be on a single line
1650 | ERROR | [x] Multiple selectors should each be on a single line
1839 | ERROR | [x] Multiple selectors should each be on a single line
1883 | ERROR | [x] Multiple selectors should each be on a single line
2245 | ERROR | [x] Multiple selectors should each be on a single line
2245 | ERROR | [x] Multiple selectors should each be on a single line
2713 | ERROR | [x] Multiple selectors should each be on a single line
3031 | ERROR | [x] Multiple selectors should each be on a single line
3031 | ERROR | [x] Multiple selectors should each be on a single line
3031 | ERROR | [x] Multiple selectors should each be on a single line
3058 | ERROR | [x] Multiple selectors should each be on a single line
3058 | ERROR | [x] Multiple selectors should each be on a single line
3058 | ERROR | [x] Multiple selectors should each be on a single line
3121 | ERROR | [x] Multiple selectors should each be on a single line
3121 | ERROR | [x] Multiple selectors should each be on a single line
3121 | ERROR | [x] Multiple selectors should each be on a single line
4046 | ERROR | [x] Multiple selectors should each be on a single line
4046 | ERROR | [x] Multiple selectors should each be on a single line
4157 | ERROR | [x] Multiple selectors should each be on a single line
4157 | ERROR | [x] Multiple selectors should each be on a single line
4157 | ERROR | [x] Multiple selectors should each be on a single line
4395 | ERROR | [x] Multiple selectors should each be on a single line
4395 | ERROR | [x] Multiple selectors should each be on a single line
4395 | ERROR | [x] Multiple selectors should each be on a single line
4443 | ERROR | [x] Multiple selectors should each be on a single line
4443 | ERROR | [x] Multiple selectors should each be on a single line
4443 | ERROR | [x] Multiple selectors should each be on a single line
4550 | ERROR | [x] Multiple selectors should each be on a single line
4550 | ERROR | [x] Multiple selectors should each be on a single line
4571 | ERROR | [x] Multiple selectors should each be on a single line
4571 | ERROR | [x] Multiple selectors should each be on a single line
4634 | ERROR | [x] Multiple selectors should each be on a single line
4696 | ERROR | [x] Multiple selectors should each be on a single line
4783 | ERROR | [x] Multiple selectors should each be on a single line
4783 | ERROR | [x] Multiple selectors should each be on a single line
4783 | ERROR | [x] Multiple selectors should each be on a single line
4845 | ERROR | [x] Multiple selectors should each be on a single line
4855 | ERROR | [x] Multiple selectors should each be on a single line
4855 | ERROR | [x] Multiple selectors should each be on a single line
4855 | ERROR | [x] Multiple selectors should each be on a single line
4855 | ERROR | [x] Multiple selectors should each be on a single line
4855 | ERROR | [x] Multiple selectors should each be on a single line
5044 | ERROR | [x] Multiple selectors should each be on a single line
5044 | ERROR | [x] Multiple selectors should each be on a single line
5129 | ERROR | [x] Multiple selectors should each be on a single line
5129 | ERROR | [x] Multiple selectors should each be on a single line
5299 | ERROR | [x] Multiple selectors should each be on a single line
5299 | ERROR | [x] Multiple selectors should each be on a single line
5299 | ERROR | [x] Multiple selectors should each be on a single line
5483 | ERROR | [x] Multiple selectors should each be on a single line
5483 | ERROR | [x] Multiple selectors should each be on a single line
5621 | ERROR | [x] Multiple selectors should each be on a single line
5763 | ERROR | [x] Multiple selectors should each be on a single line
5875 | ERROR | [x] Multiple selectors should each be on a single line
5875 | ERROR | [x] Multiple selectors should each be on a single line
5875 | ERROR | [x] Multiple selectors should each be on a single line
5899 | ERROR | [x] Multiple selectors should each be on a single line
5899 | ERROR | [x] Multiple selectors should each be on a single line
5899 | ERROR | [x] Multiple selectors should each be on a single line
5899 | ERROR | [x] Multiple selectors should each be on a single line
5899 | ERROR | [x] Multiple selectors should each be on a single line
5948 | ERROR | [x] Multiple selectors should each be on a single line
5948 | ERROR | [x] Multiple selectors should each be on a single line
5948 | ERROR | [x] Multiple selectors should each be on a single line
6174 | ERROR | [x] Multiple selectors should each be on a single line
6215 | ERROR | [x] Multiple selectors should each be on a single line
6215 | ERROR | [x] Multiple selectors should each be on a single line
6239 | ERROR | [x] Multiple selectors should each be on a single line
6239 | ERROR | [x] Multiple selectors should each be on a single line
6239 | ERROR | [x] Multiple selectors should each be on a single line
6280 | ERROR | [x] Multiple selectors should each be on a single line
6280 | ERROR | [x] Multiple selectors should each be on a single line
6318 | ERROR | [x] Multiple selectors should each be on a single line
6318 | ERROR | [x] Multiple selectors should each be on a single line
6536 | ERROR | [x] Multiple selectors should each be on a single line
6563 | ERROR | [x] Multiple selectors should each be on a single line
6563 | ERROR | [x] Multiple selectors should each be on a single line
6563 | ERROR | [x] Multiple selectors should each be on a single line
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 105 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------
Comment #9
ysarkisyan CreditAttribution: ysarkisyan commentedWe have made a lot of fixes to the coding standards.
The only remaining are related to an external library - OwlCarousel.
Can you please review to help us get this theme covered by "security advisory policy"?
Thanks
Comment #10
ysarkisyan CreditAttribution: ysarkisyan commentedCan you please help to get the security review for Agnian Material Admin Theme?
Comment #11
ysarkisyan CreditAttribution: ysarkisyan commentedComment #12
saidatomfix structure-types-list-cont children pages Commit
Comment #13
ysarkisyan CreditAttribution: ysarkisyan commentedStructure types was fixed.
Comment #14
ysarkisyan CreditAttribution: ysarkisyan commentedCan the security team review please? We have made a lot of improvements but no response so far.
Comment #15
ysarkisyan CreditAttribution: ysarkisyan commentedComment #16
ysarkisyan CreditAttribution: ysarkisyan as a volunteer commentedComment #17
apadernoThank you for your contribution! Please don't set the status Fixed nor Reviewed & tested by the community, or reviewers will not check it anymore.
Comment #18
apadernoComment #19
zymphonies-dev CreditAttribution: zymphonies-dev at Zymphonies, Midlot commentedPlease find the below review comments.
1) For accessibility, Add 'Skip to main content' in html.twig
2)You can remove Compass default line comments using 'line_comments = false'.
3)Repeated images with different size, I feel it is good to use single image and resize using CSS.
Comment #20
apadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.
Comment #21
ysarkisyan CreditAttribution: ysarkisyan as a volunteer commentedComment #22
ysarkisyan CreditAttribution: ysarkisyan as a volunteer commentedComment #23
apadernoComment #24
saesa CreditAttribution: saesa at SDOS commentedYou should fix all the errors that the pareview review shows https://pareview.sh/pareview/https-git.drupal.org-project-agnian_materia...
Comment #25
saidatomPatch to fix standards
Comment #26
apadernoThe task of reviewer is reporting what is wrong in the code, not providing patches to fix the errors.
Comment #27
apadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.