While we removed most t() calls from our tests back in #2832015: Remove translations from functional tests, it seems a few got overlooked back then, or were added in later issues.
To find them: git grep '\bt(' `find -type d -name tests`

CommentFileSizeAuthor
#13 remove_translations_from_all_tests-2870988-13.patch10.22 KBkala4ek
#11 remove_translations_from_all_tests-2870988-11.patch3.91 KBc.nish2k3
#8 remove_translations_from_all_tests-2870988-8.patch3.87 KBc.nish2k3
#4 Iss-2870988-remove_translations_from_all_tests.patch717 bytessahilsharma011
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Parent issue: » #2832015: Remove translations from functional tests
sahilsharma011’s picture

sahilsharma011 CreditAttribution: sahilsharma011 at Google Summer of Code commented
Assigned: Unassigned » sahilsharma011

I'll work on a patch.

sahilsharma011’s picture

sahilsharma011 CreditAttribution: sahilsharma011 at Google Summer of Code commented
Assigned: sahilsharma011 » Unassigned
Status: Active » Needs review
FileSize
Iss-2870988-remove_translations_from_all_tests.patch717 bytes

Patch provided. Please review.

rodrigoac’s picture

rodrigoac CreditAttribution: rodrigoac at CI&T commented
Status: Needs review » Needs work
Issue tags: -Novice +undefined

Hi people,
I am not sure if this is right, but we need to remove all usages of t() in tests ?
If yes, and after I ran 'git grep' this is the output:

$ git grep '\bt(' `find -type d -name tests` tests/search_api_test
modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm('admin/modules', $edit_enable, t('Install'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->assertSession()->pageTextContains(t('Some required modules must be enabled'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm(NULL, [], t('Continue'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm('node/add/article', $edit, $this->t('Save and publish'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm('admin/modules/uninstall', $edit_disable, t('Uninstall'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->submitForm([], t('Uninstall'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$submit = $tab == 'fields' ? $this->t('Save changes') : $this->t('Save');

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm('admin/modules', $edit_enable, t('Install'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->assertSession()->pageTextContains(t('It looks like the default setup provided by this module already exists on your site. Cannot re-install module.'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->submitForm([], $this->t('Delete'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->clickLink(t('Delete'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->submitForm([], t('Delete'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$this->drupalPostForm('admin/modules', $edit_enable, t('Install'));

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php:
$success_text = t('Content type @content_type not found. Database Search Defaults module could not be installed.', ['@content_type' => 'article']);

modules/search_api_db/tests/src/FunctionalJavascript/IntegrationTest.php:
$this->submitForm($edit, $this->t('Save'));

modules/search_api_db/tests/src/Kernel/BackendTest.php:
$this->assertResults([1, 2, 3], $results, 'Search for »foo«', ['foo'], [$this->t('No valid search keys were present in the query.')]);

tests/search_api_test/src/Plugin/search_api/backend/TestBackend.php:
'#title' => $this->t('Test'),

tests/search_api_test_hooks/search_api_test_hooks.search_api.inc:
$displays['views_page:search_api_test_view__page_1']['label'] = t('Some funny label for testing');

tests/src/Functional/IntegrationTest.php:
$this->assertSession()->pageTextNotContains(t('The listed configuration will be deleted.'));

tests/src/Functional/IntegrationTest.php:
$this->assertSession()->pageTextContains(t('Search index'));

tests/src/Functional/IntegrationTest.php:
$this->submitForm([], t('Delete'));

tests/src/Functional/IntegrationTest.php:
$this->submitForm([], t('Delete'));

tests/src/Functional/IntegrationTest.php:
$this->assertSession()->responseContains(t('Are you sure you want to delete the search server %name?', ['%name' => $server->label()]));

tests/src/Functional/IntegrationTest.php:
$this->assertSession()->pageTextContains(t('Deleting a server will disable all its indexes and their searches.'));

tests/src/Functional/IntegrationTest.php:
$this->submitForm([], t('Delete'));

tests/src/Functional/IntegrationTest.php:
$this->assertSession()->responseContains(t('The search server %name has been deleted.', ['%name' => $server->label()]));

There are several usages of t() function in tests folder yet.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Issue tags: -undefined +Novice

#5 is correct, we need to remove it from the actual tests. Keeping this issue at NW but restoring novice tag.

c.nish2k3’s picture

c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commented
Assigned: Unassigned » c.nish2k3
c.nish2k3’s picture

c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commented
Assigned: c.nish2k3 » Unassigned
Status: Needs work » Needs review
FileSize
remove_translations_from_all_tests-2870988-8.patch3.87 KB

Status: Needs review » Needs work

The last submitted patch, 8: remove_translations_from_all_tests-2870988-8.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

That's a good start, thanks!
However, when removing a t() call with arguments, you have to replace it with new FormattableMarkup() so the placeholders get replaced properly. (See test fails.)

c.nish2k3’s picture

c.nish2k3 CreditAttribution: c.nish2k3 as a volunteer commented
Status: Needs work » Needs review
FileSize
remove_translations_from_all_tests-2870988-11.patch3.91 KB

Thanks for the hint.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Needs work

Great, thanks!

There are still some left, though, in the following files:

modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTes
modules/search_api_db/tests/src/FunctionalJavascript/IntegrationTest.php
modules/search_api_db/tests/src/Kernel/BackendTest.php

(See my git grep line in the issue summary.)

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented
Status: Needs work » Needs review
FileSize
remove_translations_from_all_tests-2870988-13.patch10.22 KB

Attached updated patch.

hgunicamp’s picture

hgunicamp CreditAttribution: hgunicamp at CI&T commented
Status: Needs review » Reviewed & tested by the community

I tested the 'remove_translations_from_all_tests-2870988-13.patch' patch and it looks nice for me.

hgunicamp’s picture

hgunicamp CreditAttribution: hgunicamp at CI&T commented
Issue tags: +ciandt-contrib

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

Looks great now, thanks!
Committed.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.