Follow-up of #2828848: Prepare IntegrationTest to be executed on different backends.

All call to t() need to be removed. As a side effect we'll get rid of the PHP 5 strict warning:
PHPUnit_Framework_Exception: Strict Standards: Drupal\Tests\search_api\Functional\SearchApiBrowserTestBase and Drupal\Core\StringTranslation\StringTranslationTrait define the same property ($stringTranslation) in the composition of Drupal\Tests\search_api\Functional\ViewsTest. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed in /home/travis/build/mkalkbrenner/drupal/modules/search_api/tests/src/Functional/ViewsTest.php on line 893

CommentFileSizeAuthor
#4 2832015_4.patch22.9 KBmkalkbrenner
#4 2-4-interdiff.txt570 bytesmkalkbrenner
#2 2832015.patch22.8 KBmkalkbrenner

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new 2832015.patch22.8 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2832015.patch, failed testing.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 2-4-interdiff.txt570 bytes
new 2832015_4.patch22.9 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2832015_4.patch, failed testing.

The last submitted patch, 4: 2832015_4.patch, failed testing.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

There was an issue on the test bot itself. The tests are passing!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Great job, looks good. Thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.