[D8] Domain GoogleNews Sitemap

Hi,

Please do not assign ticket yourself.
See the workflow https://www.drupal.org/node/532400

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxcchanana2869634git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Chandni,

Kindly see the automated review of your project as its showing some errors.

Link: https://pareview.sh/node/1648

thanks
S

Hi cchanana,

I am getting following error on url: http://example.com/googlenews.xml

Uncaught PHP Exception Drupal\\Core\\Database\\DatabaseExceptionWrapper: "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'dconsole.node__field_domain_access' doesn't exist: SELECT n.nid AS nid\nFROM \n{node_field_data} n\nLEFT OUTER JOIN {node__field_domain_access} d ON n.nid=d.entity_id\nWHERE (n.status = :db_condition_placeholder_0) AND (n.type IN (:db_condition_placeholder_1, :db_condition_placeholder_2)) AND (n.created >= :db_condition_placeholder_3) AND (d.field_domain_access_target_id = :db_condition_placeholder_4) \nORDER BY n.created DESC\nLIMIT 1000 OFFSET 0; Array\n(\n [:db_condition_placeholder_0] => 1\n [:db_condition_placeholder_1] => article\n [:db_condition_placeholder_2] => page\n [:db_condition_placeholder_3] => 1492415986\n [:db_condition_placeholder_4] => harsh_com\n)\n" at /var/www/html/dconsole/core/lib/Drupal/Core/Database/Connection.php line 671

node__field_domain_access field is missing so you need to add dependency for domain_access & domain_source module in your .info.yml file.

Hi @cchanana

This module works for me. I review this module manually and did not find any error.
Finally I tested this module on pareview.sh and did not find any error or warning.
https://pareview.sh/node/1648

Thanks

@B N Pandey I think you missed something.

@cchanana

In file domain_googlenews.module file I have found a function domain_googlenews_list_nodes that is being called in GoogleNewsController.php on line 97 & 98. Which you can define with controller & also services like,

$negotiator = \Drupal::service('domain.negotiator');
$config = \Drupal::config('googlenews_admin.settings');
$db = \Drupal::database();

can be easily available in controller through injection.

This is not the application blocker but definitely not the right approach.

Removing the RTBC Tag.

Hi @cchanana,

Below are some suggestions:

1. Add package Domain instead of custom in info.yml file
2. Remove configurations when module is uninstalled
e.g:
function domain_googlenews_uninstall() {
// Remove configurations.
\Drupal::configFactory()->getEditable('googlenews_admin.settings')->delete();
}

// Display sitemap with correct XML header using http response class.
3. $response = new Response($content, Response::HTTP_OK, ['content-type' => 'application/xml']);
return $response;

instead of
header("Content-type: text/xml");
echo $content;
exit();

Apart from these, this module is working fine for me.

Hi @NarendraR,

Nice tips.

Hi @cchanana,

I tested your module and it is working fine for me. Making it RTBC.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.