Problem/Motivation

There are a number of $this->entityManager->getFieldStorageDefinitions() calls in SqlContentEntityStorageSchema. That class already has a $fieldStorageDefinitions property which is always set and already contains the same thing.

Proposed resolution

Use $this->fieldStorageDefinitions instead of $this->entityManager->getFieldStorageDefinitions() in SqlContentEntityStorageSchema.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 2867325-5.patch4.18 KBjoshmiller
#4 2867325-2.patch4.18 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Active » Needs review

Here we go. Will open the issue for which this is a blocker in a minute, but since this is such a harmless change (and the other one will be a bit contentious I fear) wanted to have this separately.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Issue tags: -blocker

Actually that's a bug I found with #2346019: Handle initial values when creating a new field storage definition that I had applied locally. So this is still a nice quickfix, but does not actually block anything.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
FileSize
2867325-2.patch4.18 KB

D'oh, maybe I should actually upload a patch, no?

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller at Acro Commerce commented
FileSize
2867325-5.patch4.18 KB

Rerolled. Offset on HEAD by 10 lines.

FWIW, RTBC .. though since I rerolled, I don't think I can RTBC.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Makes sense.

This might also help with issues related to uninstalling entity types/field storage definitions.

  • catch committed a50adc9 on 8.5.x 
    Issue #2867325 by tstoeckler: SqlContentEntityStorageSchema needlessly...

  • catch committed 881d412 on 8.4.x 
    Issue #2867325 by tstoeckler: SqlContentEntityStorageSchema needlessly...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.