Menu items that link to an empty administration page are not hidden

This doesn't seem like a core bug per-se. For these certain listing pages you need to add a check beyond the permissions check?

Just gave it a try and this patch works, fixing the described issue.

Probably a duplicate of the core issue #296693: Restrict access to empty top level administration pages, but if the patch works :)

The core has had no love for years.

Common issue in the discussion #2863330: Modifying the admin menu: site building examples

There is also Administration links access filter module too.

Well, as there is already a core patch + a module for fixing it, it would be nice to keep Admin Toolbar clean. A solution would be to integrage Administration links access as a submodule of Admin Toolbar untill this bug in fixed in the core.

I'll ask the maintainer of Administration link access filter and add it at least to the Admin toolbar description page.

Hi there,

I'm the maintainer of Administration link access filter and I'd fully support this idea of merging this in as sub module - also see my comment at #2866592-2: Merge into Admin Toolbar ?

Please feel free to contact me or even just grab the code and use it :) I'm also frequently online on IRC, most of the time hanging around in #drupal-commerce channel

best regards,
Andreas

already a core patch

Please don't wait for core lol

catch commented 17 November 2010 at 14:29
Version:	7.x-dev	» 8.x-dev
Priority:	Critical	» Major
Issue tags:	-Release blocker, -D7 API clean-up	

lol, the only positive thing is that it finally wasn't treated as release blocker for D8 :D

Patch #3 applied on 1.19 and it works without errors. (The module also works.)

After updating to 8.3.4 the core module Workflows appears as empty menu item. Is this related to this issue?

Module is disabled.

The patch works fine for me.

Actually it turns out that the "content" menu link gets removed.

Here is an updated version, rerolled for last dev...

@joekers: Could you check if the user have the right to add some content? (Don't forget to clear the cache before testing)

Yep the user has access, they can see and go to the content page without the patch. I first thought it might be due to it not having any children elements, but the "People" link still shows..

@joekers:

You are right... looking at the code, if the user doesn't have the right to access
one of the submenu item of any menu link, the former will be removed (Access:Neutral)

In your use case, the user have only "Access the Content overview page" but he can't add content or anything else that any submenu of the content menu item can provide...

I don't see any easy way to change this... but I think this patch doesn't solve the problem as it is adding another "bug"!

The user has access to add content, it was access to the comments (which is the only link under Content) that allowed the Content link to show. This was better than showing all the other unaccessible links for me so I've settled on giving them this permission for now.

FYI, I am using another patch: https://www.drupal.org/node/2731369#comment-12140124 which adds all the local tasks in the admin menu...
This is why I have other sub items in the content menu...
I think, this can solve your use case without adding the comment permission... (But this will not solve this "bug")

Here is a new patch, with fixed tests

+++ b/admin_toolbar.module
@@ -88,3 +91,43 @@ function toolbar_tools_menu_navigation_links(array $tree) {
+ * Removes menu items with subtrees in which none of the children are accessible.
+ *
+ * This fixes a regression in Drupal 8 core and reverts to the Drupal 7 core
+ * behavior, by hiding the menu items.

While I understand this is the (very good) reason for this, do we actually want to say this in the code?

I think the first line says what it does; we might not need further explanation.

Here's a reroll of #24 as it no longer applied because the administer site configuration permission in the test was added in #2887439: Fix test.

Also removed the "This fixes a regression..." comment noted by @rootwork in #25 as I also agree it's probably not needed.

Path #26 also doesn't apply anymore. Here's a new one. If it passes the tests, can it be commited before this happens again, please?

Oops, forgot to update the test.

@eme as this will be fixed in the future in core, I think that we should merge the @agoradesign project (admin_links_access_filter) as a submodule of Admin Toolbar, so when the problem will be fixed in core we can just delete the submodule, and we don't need to change nothing inside the Admin Toolbar module. I don't know what do you think. In my opinion this can be a great feature for the v1.21.

I do agree that it does not belong inside Admin Toolbar. Or maybe a separate module that we can deprecate ?

@eme we can create a submodule of Admin Toolbar to fix this problem and put inside the code of the admin_links_access_filter module. I think that @agoradesign think the same #2866592: Merge into Admin Toolbar ?

Ok, all right and let's go :)

@eme, ok, I will work on this in the next days, for the moment I will open the issue and close this as duplicate :-)

Well the adventure has just started in #2917704: Add Administration links access filter module as Admin Toolbar submodule

Closing as duplicate.

Once we finish I will add credit in the issue to all the people that help here ;-)

Well the job in #2917704: Add Administration links access filter module as Admin Toolbar submodule is done!

thanks to @all.

Adding admin_links_access_filter module (sub-module of admin_toolbar) fixed the issue for me. Thanks

Enable this module Admin Toolbar Links Access Filter to hide an empty administration page from the menu.