Merge into Admin Toolbar ? [#2866592]

Hello,

We're discussing about fixing this bug in Admin Toolbar (see #2855786: Menu items that link to an empty administration page are not hidden) but as there is a core discussion + your module, that would be better to keep Admin toolbar clean of this fix hoping that the core issue will be resolved asap.

I have put your module as a link in Admin Toolbar description, but maybe we could add it directly as a temporary submodule of admin toolbar and make you as co-maintainer on this part ? This way, the maximum of people could use it and it'll be very easy to remove whenever the core is fixed ?

Tell me what you thing about it !

Regards,

Comments

Comment #1

4 April 2017 at 07:49

eme created an issue. See original summary.

Comment #2

agoradesign commented 4 April 2017 at 08:14

Hi,

this is definitely a good idea! As I've already wrote on the project description page, there is no hard dependency on admin_toolbar yet, but it is very recommended to use it and maybe does not make sense to not using it. In the past, some issue reports were based on installations without admin_toolbar (see #2835727-14: Structure and Configuration Menus Disappeared in Latest Update and #2839918-3: Menu parent item with "authenticated user" not respected, so I'll absolutely support this idea :)

It's a very friendly and nice proposal to add me as co-maintainer on that part, which I'd accept of course, but is not a necessary step for me. In fact, I created this module as a side product of one our own client work projects because the empty links became more and more disturbing, the more offen we've encountered them. Merging this into admin_toolbar would be a great benefit for me too, as I'm not actively working on this module. I just actively use it in every single project by myself and I'm trying to respond as good and quick to every single issue reported here. Getting helping hands here never harms :)