Hi

When I add a view as an additional top menu item and give the permission by role to "authenticated user", the access check fails and the item is missing. When I explicitly grant the role of the user to the view (e.g. Editor) it works.

Thanks for reviewing this.

CommentFileSizeAuthor
#2 skip_check_for_views_pages-2839918-2.patch766 bytesagoradesign

Comments

grahl created an issue. See original summary.

agoradesign’s picture

agoradesign commented
Status: Active » Needs review
StatusFileSize
new skip_check_for_views_pages-2839918-2.patch766 bytes

Hi,
unfortunately I was not able to reproduce this, although I followed your instructions. I've tried a few different setups - with admin_toolbar and admin_toolbar_tools enabled, only with admin_toolbar enabled, without both modules - every setup worked as expected.

However, I've attached a patch, which could probably solve your problem. Within admin_links_access_filter_preprocess_admin_block_content() I'm currently skipping access check on any link that is pointing to a Views page because the route-based access check didn't work there properly. That also means that links to non-accessible Views pages still show up there. At the time of writing these lines, I've also added a TODO comment there to find a generic solution instead of skipping the check.

The attached patch is copying these lines to the menu item filtering process. However, this is just a quick shoot from the hip, just to see, if this would solve your problem. Before I'd commit this, some further investigation would be needed, e.g. why I only inserted this check in the mentioned admin_block_content preprocess, but not in the menu preprocess.

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Closed (cannot reproduce)

Thank you for your patch, however, it did not solve my problem.

I can now amend that the role itself does not actually cause the problem but something in the way the menu is built does.

I can reliably recreate the error but only on one site by clearing the entire cache. I get into a consistent state if I use admin_toolbar_tools to just flush the routing and menu cache or if I save a View. If I attempt to run flush_menu() procedurally to narrow things down I am not able to get into a consistent state. The problem occurs without having admin_toolbar_tools or admin_toolbar installed.

I am closing this issue since I am not able to produce a test case with a clean site. I've solved my specific problem just by unsetting the few items I need to not be available by hand.