Local tasks don't show in the toolbar

Content > media does not seem to come from core, does it ?

About taxonomy, see #2518202: Change default link to taxonomy.

I think that what we face here is that tab links are not auto-generated as menu links with Admin Toolbar Extra Tools. That would be nice but it needs a deeper interaction between tab and menu links. Drupal has a strict separation of concern between the two.
Still that's not something that is impossible but it needs quite a lot of work. We should think at it as a future feature as this issue suggests.

I'd say this is a bug, and a pretty major one at that.

Patch works for me, looking at the Content menu, but it needs some work with formatting, and also #7 says that there are some functional problems with it.

Eg:

+++ b/admin_toolbar_tools/admin_toolbar_tools.module
@@ -454,6 +454,83 @@ function admin_toolbar_tools_menu_links_discovered_alter(&$links) {
+            $exists = false;
+            $param=false;

Should be FALSE in caps, and need space both side of = (here and in other places too).

I wasn't able to get this to work when I installed but did cleanup a lot of the basic code style issues. One note we should try to look at here is we are 6 layers deep in if statements and indention on the patch. Wondering if we can clean this up any or execute this without looping through all existing links in the menu system.

Also setting back to feature request as even though this was in D7 version it hasn't been part of D8 which isn't a bug as it isn't existing functionality. Many modules going from D7 to D8 lost or changed functionality.

+++ b/admin_toolbar_tools/admin_toolbar_tools.module
@@ -468,6 +468,83 @@ function admin_toolbar_tools_menu_links_discovered_alter(&$links) {
+  foreach ($links as $key => $link) {
+    if (isset($link['route_name'])) {

Within a foreach loop, an alternative pattern to lots of nested ifs is to line them up in sequence and bail the loop with continue:

foreach (thing) {
  if (rubbish) {
    // Skip if rubbish.
    continue;
  }
  if (not interesting) {
    // Skip if not interesting.
    continue;
  }

 // Now do something if still here.
}

I tend to prefer that, as I find it more readable.

This is nice, seems to work well here on a pretty big site with lots of modules.

I think quite a few other hardcoded local tasks could be removed in favor of the generic solution. Especially if it would include local actions as well, which could be a separate issue. But that too could be a follow-up.

The problem was that we were adding this to the array early on in the loop:

        $links[$key . '_' . $local_route]['route_parameters'] = $link['route_parameters'];

and then sometimes bailing on the iteration, and so leaving a malformed link.

Here's an updated patch, with a few other tweaks too.

Having the media module installed I have the following error:

    Notice: Undefined index: entity.file_type.collection in admin_toolbar_tools_menu_links_discovered_alter() (line 596 of modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.module).

    admin_toolbar_tools_menu_links_discovered_alter(Array, NULL, NULL) (Line: 501)
    Drupal\Core\Extension\ModuleHandler->alter('menu_links_discovered', Array) (Line: 168)
    Drupal\Core\Menu\MenuLinkManager->getDefinitions() (Line: 191)
    Drupal\Core\Menu\MenuLinkManager->rebuild() (Line: 61)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->menuLinksRebuild() (Line: 49)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) (Line: 108)
    Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) (Line: 192)
    Drupal\Core\Routing\RouteBuilder->rebuild() (Line: 83)
    Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild() (Line: 1141)
    drupal_flush_all_caches() (Line: 145)
    Drupal\admin_toolbar_tools\Controller\ToolbarController->flushAll()
    call_user_func_array(Array, Array) (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
    Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
    call_user_func_array(Object, Array) (Line: 153)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
    Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
    Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
    Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
    Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
    Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

    Notice: Undefined index: entity.file_type.collection in admin_toolbar_tools_menu_links_discovered_alter() (line 596 of modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.module).

    admin_toolbar_tools_menu_links_discovered_alter(Array, NULL, NULL) (Line: 501)
    Drupal\Core\Extension\ModuleHandler->alter('menu_links_discovered', Array) (Line: 168)
    Drupal\Core\Menu\MenuLinkManager->getDefinitions() (Line: 191)
    Drupal\Core\Menu\MenuLinkManager->rebuild() (Line: 61)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->menuLinksRebuild() (Line: 49)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) (Line: 108)
    Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) (Line: 192)
    Drupal\Core\Routing\RouteBuilder->rebuild() (Line: 83)
    Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild() (Line: 1141)
    drupal_flush_all_caches() (Line: 145)
    Drupal\admin_toolbar_tools\Controller\ToolbarController->flushAll()
    call_user_func_array(Array, Array) (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
    Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
    call_user_func_array(Object, Array) (Line: 153)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
    Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
    Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
    Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
    Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
    Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

    Notice: Undefined index: entity.file_type.collection in admin_toolbar_tools_menu_links_discovered_alter() (line 596 of modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.module).

    admin_toolbar_tools_menu_links_discovered_alter(Array, NULL, NULL) (Line: 501)
    Drupal\Core\Extension\ModuleHandler->alter('menu_links_discovered', Array) (Line: 168)
    Drupal\Core\Menu\MenuLinkManager->getDefinitions() (Line: 191)
    Drupal\Core\Menu\MenuLinkManager->rebuild() (Line: 61)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->menuLinksRebuild() (Line: 49)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) (Line: 108)
    Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) (Line: 192)
    Drupal\Core\Routing\RouteBuilder->rebuild() (Line: 83)
    Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild() (Line: 1141)
    drupal_flush_all_caches() (Line: 145)
    Drupal\admin_toolbar_tools\Controller\ToolbarController->flushAll()
    call_user_func_array(Array, Array) (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
    Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
    call_user_func_array(Object, Array) (Line: 153)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
    Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
    Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
    Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
    Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
    Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

    Notice: Undefined index: entity.file_type.collection in admin_toolbar_tools_menu_links_discovered_alter() (line 596 of modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.module).

    admin_toolbar_tools_menu_links_discovered_alter(Array, NULL, NULL) (Line: 501)
    Drupal\Core\Extension\ModuleHandler->alter('menu_links_discovered', Array) (Line: 168)
    Drupal\Core\Menu\MenuLinkManager->getDefinitions() (Line: 191)
    Drupal\Core\Menu\MenuLinkManager->rebuild() (Line: 61)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->menuLinksRebuild() (Line: 49)
    Drupal\Core\EventSubscriber\MenuRouterRebuildSubscriber->onRouterRebuild(Object, 'routing.route_finished', Object) (Line: 108)
    Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('routing.route_finished', Object) (Line: 192)
    Drupal\Core\Routing\RouteBuilder->rebuild() (Line: 83)
    Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild() (Line: 1141)
    drupal_flush_all_caches() (Line: 145)
    Drupal\admin_toolbar_tools\Controller\ToolbarController->flushAll()
    call_user_func_array(Array, Array) (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
    Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
    call_user_func_array(Object, Array) (Line: 153)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
    Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
    Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
    Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
    Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
    Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

And see the pictures for other problems:

@adriancid: That error sounds like it is related to the file_entity module, are you using both file_entity and media? that doesn't sound like a good idea. I think that should be investigated, but I actually can't reproduce that file_entity enabled and I also don't see those menu links added in the wrong place anymore.

A client reported that this was adding additonal menu links to e.g. edit terms into non-admin menus, I think they don't belong there, so I added a check to ignore all non-admin menu links, I don't think that admin_toolbar should mess with those other menus. If someone thinks there is a use case for that, it could be made configurable, but that's IMHO quite likely to mess up public menus and a bad idea.

It should also be possible to add a similar check to prevent creating empty menu links.

Thanks to @all, this is a great improvement to the module!

Thanks @Berdir for the fix, and yes I have the two modules you mentioned because is a test site with a lots of module inside, and usually I install and keep the module in the site, when the site crash, I install a fresh one to start again adding modules to test :-)

I get a similar error to @adriancid with the workflow module installed. Changing line 599 to: if (!empty($link['parent']) && isset($links[$link['parent']])) { fixes it for me... I will create another issue around this.