[D7] Forgot Email

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxveerasekarr892852598git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please resolve the https://pareview.sh/node/1149 errors

Its spacing and some other functional error.

And after installing, Forgot email tab display on login form.

I have seen this error.

Hi @veerasekar.r89

My manual review have been given below :

1. Implement hook_help in your module file.
2. Either you use t() in all menu items or just remove them.
3. check spelling on line 129
4. Add proper comments with param and return type used in function.

Hi @veerasekar.r89

If you can add some more information in readme.txt regarding how to access this feature then this will be helpful forusers.

1 . Got error while trying to configure Forgot email at admin/config/people/forgot_email

" unable to handle this request"

2 . Also before configuring Forgot Email settings the Forgot email tab should not be displayed on login form

Please review again with latest D7 version.

@veerasekar.r89

Please fix following issue.

Fatal error: Call to undefined function filter_filter() in /var/www/html/drupal7-1/sites/all/modules/forgot_email/forgot_email.module on line 15

Suggestion:

1. Forgot email tab should be come on user login page once we configured setting.
2. Add new link on login block "forgot email" It will show more visibility for user to access this functionality.

@veerasekar.r89

Here is the test results of my initial manual review

1. Log Messages: Need to fix
Notice: Use of undefined constant forgot_email_access - assumed 'forgot_email_access' in forgot_email_menu() (line 29 of /Users/shamas_mac/Sites/drtest/sites/all/modules/forgot_email/forgot_email.module)

Notice: Use of undefined constant forgot_email_access - assumed 'forgot_email_access' in forgot_email_menu() (line 39 of /Users/shamas_mac/Sites/drtest/sites/all/modules/forgot_email/forgot_email.module).

2. Request
I think you should add Forgot Email Link in User Login block also. I can't see it in login block see screenshot

Hi Below are my reivews:

1:
Please decribe more details in readme.TXT for
admin/config/people/forgot_email
As m not getting any value in dropdown of Choose Field.

2:
Please use drupal_exit() instide exit in forgot_email_resendpass function.

3:
You are seting variable forgot_email_field. Please delete this variable in .install file.

@rajveergang : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

@Abhishek,

Its not an application blocker, It should be in RTBC...

Moving it to "Needs Work". Use drupal_exit() and delete all the setting variable on module uninstall as suggested by @rajveergang at #14.

Place the below code inside a module .install file to delete the setting variable on uninstall.

/**
 * Implements hook_uninstall().
 */
function forgot_email_uninstall() {
  // Delete variables.
  variable_del('forgot_email_field');
}

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @veerasekar.r89
I have checked your module on pareview.sh (https://pareview.sh/node/1149)

Please fix coding standard issues:
http://www.awesomescreenshot.com/image/2467967/320eeb4b389509d2a62124974...

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

I think displaying all email address matching certain field from user profile is providing more information to hacker. Can we mask the email address instead of showing them in plain text?

Like Facebook do - https://b-i.forbesimg.com/adamtanner/files/2014/01/facebook1.jpg

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Actually, what reported in #25 is information breach. Only users with the permission to administer users should be able to see the email used from users.
If a site would install this module, as it is written now, a spammer could easily collect emails used from users with an account on the site. There are many bad things that hackers could do knowing somebody is using an email on a site, for example sending an email making them think the site is asking to change password, and steal the account password.

I can see a use case for the module. In the past, I bought a new computer because my old one got broken, and had to set all my emails in the new computer. I first set up the ones I use more frequently, but it could happen I forgot to set up the one I use for a Drupal account, and when I visited that Drupal site, I noticed I could not remember the password. Knowing which email I set for that site would have helped.

This doesn't mean the module should show any matching emails without identifying the user to whom the matching emails are shown.

function forgot_email_form_alter(&$form, &$form_state, $form_id) {
  switch ($form_id) {
    case 'user_login':
    case 'user_login_block':
      $items = array();
      $items[] = l(t('Create new account'), 'user/password', array('attributes' => array('title' => t('Create a new user account.'))));
      $items[] = l(t('Request new password'), 'user/password', array('attributes' => array('title' => t('Request new password via e-mail.'))));
      $items[] = l(t('Forgot Email?'), 'user/email', array('attributes' => array('title' => t('Forgot Email.'))));
      $form['links'] = array('#markup' => theme('item_list', array('items' => $items)));
      break;
  }
}

That code is wrong because it is adding links Drupal already adds, using the wrong paths. user/password is used also for Create new account.

See user_login_block().

  if (variable_get('user_register', USER_REGISTER_VISITORS_ADMINISTRATIVE_APPROVAL)) {
    $items[] = l(t('Create new account'), 'user/register', array(
      'attributes' => array(
        'title' => t('Create a new user account.'),
      ),
    ));
  }
  $items[] = l(t('Request new password'), 'user/password', array(
    'attributes' => array(
      'title' => t('Request new password via e-mail.'),
    ),
  ));

Hello

There are some typo errors please check and fix

Today every user have multiple E-mail ids So they forgotten which E-mail address registered in a Site.
This module helps to user can known which E-Mail Address they registered with a Site and then they can reset the password .

@kiamlaluno I have mentioned about the English grammar mistakes in Description of module, not about the functionality.

I apologize: It seemed you were commenting about the module.

There are many errors in that description, such as the grammar of every user have, which E-mail address registered in a Site, and This module helps to user can known; the spelling of E-mail ids, E-mail, and Site.
Those are not application stoppers, though. It would be nice if the OP would fix them, but there is a more serious error to fix.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.