Problem/Motivation

tvi_submit_handler copies values from the related vocabulary entity to a new configuration file. By copying the UUID though, we ensure though that config import no longer works. CMI detects renames when two entries have the same UUID before and after some changes.

Proposed resolution

Don't copy the UUID over.

Remaining tasks

Review/commit

User interface changes

n/a

API changes

Data model changes

Comments

dawehner created an issue. See original summary.

dylan donkersgoed’s picture

Status: Active » Needs review
StatusFileSize
new3.06 KB

Ran into this issue myself, here's a patch. There doesn't seem to be an actual corresponding config entity and I don't think the uuid is actually used for anything so it looks like just taking out the one line and updating the tests is enough.

Note that this won't fix existing config - you'll need to manually uncheck the tvi option on the vocabulary/term, save it, then load it and reconfigure it for each previously configured vocabulary/term.

dawehner’s picture

Thank you for providing a patch!
Yeah I'm not sure we can do much for existing content, as the API for example makes it impossible to change a UUID of a config entity.

star-szr’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I closed #2883119: StorageComparer thinks tvi.taxonomy_vocabulary.NAME.yml is a renamed version of taxonomy.vocabulary.NAME.yml as a duplicate of this issue.

I verified that the patch removes all references to uuid from the module. Not sure it's worth writing a test here, so setting to RTBC.

kristiaanvandeneynde’s picture

Please also add credit for legolasbo for his patch in the other issue.

sittard’s picture

Thanks for this patch. I've tested this and can confirm it's working as expected. Please can one of the maintainers update the release to include this patch. It's a critical fix especially now with the Drupal 8 era of config/sync.

kevinquillen’s picture

Assigned: Unassigned » kevinquillen

kevinquillen’s picture

Status: Reviewed & tested by the community » Fixed
kevinquillen’s picture

dawehner’s picture

Thank you @kevinquillen!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.