Core's StorageComparer class thinks tvi.taxonomy_vocabulary.NAME.yml is a renamed version of taxonomy.vocabulary.NAME.yml. This is caused by the fact that tvi_submit_handler sets the configuration entity's uuid to the same uuid as the vocabulary.
This isn't a problem when the tvi config is imported separately from the vocabulary config, but when they get imported together StorageComparer checks their uuids and falsely determines that one is actually a rename of the other. tvi is obviously wrong here because a config entity's uuid should be set by Drupal's config system and not by any implementing code.
The attached patch fixes this by storing the uuid under the vocabulary_uuid key.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | storagecomparer_thinks-2883119-3.patch | 2.7 KB | legolasbo |
| uuid-should-not-be-set.patch | 3.12 KB | legolasbo |
Comments
Comment #2
legolasboComment #3
legolasboFurther investigation shows that we actually don't need to store the vocabulary's uuid, because that value never gets accessed by the code.
Comment #4
kristiaanvandeneyndeSetting UUIDs is bad m'kay :)
Comment #5
star-szrClosing in favour of the older #2852645: tvi_submit_handler() should not copy the UUID over that has the same diff.
Comment #6
kristiaanvandeneyndeCould you please add legolasbo to the people receiving credit in the other issue then?
Comment #7
star-szr@kristiaanvandeneynde a maintainer of this project would have to do that, feel free to comment on the other issue to ask for that.