[D7] PLY NWS Viewer

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxc4ilus2843513git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi c4ilus,
Your module is not using drupal coding standards.
please change
$element['alter_opacity'] = [
'#type' => 'checkbox',
'#title' => t('Apply opacities on objects'),
'#default_value' => $settings['alter_opacity'],
];
to
$element['alter_opacity'] = array(
'#type' => 'checkbox',
'#title' => t('Apply opacities on objects'),
'#default_value' => $settings['alter_opacity'],
);

Same with $formatter['ply_nxs_viewer_models'] = [
$theme['ply_nxs_viewer_formatter'] = [

https://www.drupal.org/docs/develop/standards/coding-standards#array

Thanks,
Khurram

Minor coding standard issues are surely not application blockers. Anything else that you found or should this be RTBC instead?

Hi @klausi
Correct me if I am wrong but as far as I can see Drupal 7 does support PHP version 5.3 at the moment (https://www.drupal.org/docs/7/system-requirements/php). Using short array syntax will be a syntax error.

Thanks,
Khurram

PHP 5.3 has long been unsupported, so I think it's fine if new modules rely on supported versions of php. That's why short array syntax usage should not be an application blocker.

Hi @c4ilus
I have checked your module:
1:- Implement hook_help
2:- pareview.sh (https://pareview.sh/node/900) Need to working on coding standards.

@c4ilus

Add .git extension to the end of "git clone --branch 7.x-1.x https://git.drupal.org/sandbox/c4ilus/2843513.git ply_nxs_viewer"

Regards
Satyam

Sorry forgotten to change status, now changing

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-ply_nxs_viewer...

Review of the 7.x-1.x branch (commit 28cbf2d):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
• The ply_nxs_viewer.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation: https://www.drupal.org/project/v3dm

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

no issues

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.