VG Responsive theme is fully responsive and developed by Drupal 8 with bootstrap layout. This theme is mainly designed for simple website without side bar in pages.

Project Link:
https://www.drupal.org/sandbox/venu_gopal/2838317

Project Git url:

git clone --branch 8.x-1.x https://git.drupal.org/sandbox/venu_gopal/2838317.git vg_responsive_theme
cd vg_responsive_theme

Comments

venu_gopal created an issue. See original summary.

venu_gopal’s picture

Title: VG Responsive theme » [D8] VG Responsive theme
PA robot’s picture

Status: Active » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvenu_gopal2838317git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

venu_gopal’s picture

Priority: Normal » Major
Status: Needs work » Needs review

Removed all errors from https://pareview.sh/. Please review it

Project URL : https://git.drupal.org/sandbox/venu_gopal/2838317.git

venu_gopal’s picture

vivek.addweb’s picture

Status: Needs review » Needs work

Automated Review

Error from pareview.sh

Review of the 8.x-1.x branch (commit cf7576e):

  • Remove all backup files from your repository:

        ./README.txt~
        

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

README.txt doesn't provide detailed information & third party file details.

Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[security requirements. No: List of security issues identified.]

t() function is not used in theme.

This review uses the Project Application Review Template.

venu_gopal’s picture

Hi @vivek.addweb

Thanks for reviewing my theme

Removed errors, please check and let me know

Thanks for review

venu_gopal’s picture

Status: Needs work » Needs review
deepali_agarwal’s picture

Status: Needs review » Needs work

Automated Review

Review of the 8.x-1.x branch (commit e2ca412):

FILE: /root/repos/pareviewsh/pareview_temp/vgtheme.theme
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 19 spaces but found 1 space

Manual Review

Found some points that should be taken care of:

  1. It would be better to include the screen-shot of theme as it gives better idea and easy recognition for theme.
  2. As a general practice style.css should be called after bootstrap, font-awesome css etc.
  3. Found some unnecessary spacing in vgtheme.libraries.yml file on line 7.
  4. vgtheme.breakpoints.yml file is empty, so can be removed.
  5. Please add some detailed information in README.txt.
  6. page.html.twig is not at all formatted, which makes it very difficult to read/edit the code.
  7. Add code to check if main_menu block region is empty.
  8. Drupal behaviour is not used in js.
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.