The use of the t() function on line 83 of /src/Plugin/Field/FieldFormatter/ViewsReferenceFieldFormatter.php is causing the double escaping of special characters such as &.

CommentFileSizeAuthor
#4 double_epscaping_special_characters_bug-2838413-4.patch711 bytesjoekers
#3 double_epscaping_special_characters_bug-2838413-3.patch727 bytesznak

Comments

jerdavis created an issue. See original summary.

NewZeal’s picture

NewZeal commented

Are you referring to the title as follows?:

$title_render_array = array(
          '#markup' => '<div class="viewsreference-title">' . t('@title', ['@title'=> $title]) . '</div>'
 );

It's probably the @ which is cleaning out the ampersand. I'll change to ! in the next release and we can see if that helps.

znak’s picture

znak commented
Status: Active » Needs review
StatusFileSize
new double_epscaping_special_characters_bug-2838413-3.patch727 bytes

Patch for your module

joekers’s picture

joekers
Primary language English
commented
StatusFileSize
new double_epscaping_special_characters_bug-2838413-4.patch711 bytes

Thanks for your patch but it looks like the "!" placeholder has now been removed so we get the following error:
Invalid placeholder (!title) in string: !title in Drupal\Component\Render\FormattableMarkup::placeholderFormat() (line 235 of core/lib/Drupal/Component/Render/FormattableMarkup.php).

It seems like strings are sanitised in t() so we shouldn't need any placeholders here, try the attached patch.

NewZeal’s picture

NewZeal commented

Can people download the latest dev code, check this change is in the code, test and report back so we can go beta: https://www.drupal.org/node/2846411

joekers’s picture

joekers
Primary language English
commented
Status: Needs review » Fixed

I've tested again and it's working for me - marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.