Time to go Beta

I agree, I think it would be good to fix bugs #2846625: Views reference field does not allow more than 1 argument for view and #2838413: The use of the t() function in ViewsReferenceFieldFormatter.php causes double escaping of the View Title beforehand so we can start a clean slate.

I also think we should do some code cleanup so we are following the coding standards, but that could be done during beta phase.

Whilst trying to test the latest commits, the display ID select list has stopped working - any ideas?

I think we should have tested the patches individually before committing them all to dev and then testing.

It looks like the old code in getViewDisplayIds() has been added back which prevents the display ID select list from working properly.

I can't see a commit where it was changed though so I'm confused...

In my last commit to master the code was:

  protected function getViewDisplayIds($entity_id) {
    $views =  \Drupal\views\Views::getAllViews();
    $options = array();
    foreach ($views as $view) {
      if ($view->get('id') == $entity_id) {
        foreach ($view->get('display') as $display) {
          $options[$display['id']] = $display['display_title'];
        }
      }
    }
    return $options;
  }

And now the code is:

  protected function getViewDisplayIds($entity_id) {
    $views =  \Drupal\views\Views::getAllViews();
    $options = array();
    $view_plugins = $this->getFieldSetting('plugin_types');
    foreach ($views as $view) {
      if ($view->get('id') == $entity_id) {
        foreach ($view->get('display') as $display) {
          if (in_array($display['display_plugin'], $view_plugins)) {
            $options[$display['id']] = $display['display_title'];
          }
        }
      }
    }
    return $options;
  }

Ah ok, sorry I didn't realise you'd pushed that. Now that I've selected the displays in the fields settings I can see them available in the field :)

I haven't heard back from the guy who reported the issue - I think it still needs fixing for multiple arguments. Not sure how you feel about releasing the beta without this functionality?

I can spend some time on trying to fix it as it doesn't look like EugeneChechel has had time.

@New Zeal would be great to know your thoughts on whether these should be added to the module, and whether you think they'd be good to get in during alpha?
#2846134: "Advanced Settings" Checkbox/Fieldset
#2858980: Add checkbox to show/hide pager - this now applies to 2.x branch
#2848762: Add Number/Offset Field - this now applies to 2.x branch
#2860736: Add option to limit results - this now applies to 2.x branch

I don't think they'd take long to complete, if you're happy for them to be added under an "Advanced" section then I'll get them committed asap.

Yeah I'll go ahead with making a single serialised field for all our advanced settings.

Sure I'm fine with you moving to beta - the only thing I think we could wait for is progress on #2857697: Limit the initial Display IDs to those pre-selected in the field settings page. - where I think some regression has crept in, but we could always fix that later.