Empty viewsreference argument breaks contextual filter default value handling [#2847192]

A viewsreference field with no argument supplied is not working when referencing a view block containing a contextual filter that sets 'Provide default value' of 'Content ID from URL'.

In this case, an empty string argument is passed to views_embed_view() in ViewsReferenceFieldFormatter::viewElements() and views is not applying default value handling. Apparently views_embed_view() needs a NULL argument to recognize the filter value is unavailable.

One workaround is to coerce empty string arguments to NULL in ViewsReferenceItem::setValue().

Comment	File	Size	Author
#3	viewsreference-empty-argument-2.patch	745 bytes	keithm
	viewsreference-empty-argument-1.patch	715 bytes	keithm

Comments

Comment #1

26 January 2017 at 22:47

keithm created an issue. See original summary.

Comment #2

keithm commented 27 January 2017 at 11:21

Title:	Empty arguments break views contextual filter default value handling	» Empty viewsreference argument breaks contextual filter default value handling
Issue summary:	View changes

Comment #3

keithm commented 27 January 2017 at 12:08

Status	File	Size
new	viewsreference-empty-argument-2.patch	745 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	viewsreference-empty-argument-1.patch	715 bytes

Rerolled patch to detect missing argument key.

Comment #4

NewZeal commented 29 January 2017 at 22:24

Keith,

Can you download the latest dev code, check your change is in the code, test and report back so we can go beta: https://www.drupal.org/node/2846411

Thanks

Kent

Comment #5

keithm commented 30 January 2017 at 16:44

Kent,

Confirming patch #3 is included in commit c71890f07e8632ce7fe6984b2961782e426d85bd, and tested processing of empty viewsreference argument works as designed.

For future reference, would you please give credit to issue contributors in your commit messages? The template is given below in 'Credit & commiting'.

Thanks.

Keith