[D7] Instagram Scrape Feed

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Please fix the issue reported on https://pareview.sh/node/434

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[No: Causes] module duplication and/or fragmentation.

Master Branch

[Yes: Follows ] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows ] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

No: List of security issues identified.]

1. URLs must be checked with check_url() and You need to sanitize user provided input before printing into #markup.

Example Code :

		  $posturl = 'https://www.instagram.com/p/' . $posts[$i]['code'];
		  $block['content']['#markup'] .= '<div class="instagram-row column-' . $column_count . ' ' . $posttype . '">';
		  $block['content']['#markup'] .= '<a href="' . $posturl . '" target="blank"><img src="' . $imgurl . '" alt="' . $caption . '" /></a>';
		  $block['content']['#markup'] .= '<span class="stats"><span class="likes"><span>likes</span>' . $likes . '</span><span class="comments"><span>comments</span>' . $comments . '</span></span>';
		  if ($max_length != 0) {
		    $block['content']['#markup'] .= '<span class="caption">' . $caption . '</span>';
		  }
		  $block['content']['#markup'] .= '</div>';

2. Add t() for user facing text.

Example

$block['content']['#markup'] .= 'Set a user name to view the posts';

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. suggestion : Please use l() instead <a> tag and theme() instead of writing html tags.

Example Code :

		  $posturl = 'https://www.instagram.com/p/' . $posts[$i]['code'];
		  $block['content']['#markup'] .= '<div class="instagram-row column-' . $column_count . ' ' . $posttype . '">';
		  $block['content']['#markup'] .= '<a href="' . $posturl . '" target="blank"><img src="' . $imgurl . '" alt="' . $caption . '" /></a>';
		  $block['content']['#markup'] .= '<span class="stats"><span class="likes"><span>likes</span>' . $likes . '</span><span class="comments"><span>comments</span>' . $comments . '</span></span>';
		  if ($max_length != 0) {
		    $block['content']['#markup'] .= '<span class="caption">' . $caption . '</span>';
		  }
		  $block['content']['#markup'] .= '</div>';

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hello Collins405,

I have had reviewed few files off of module and below are my findings. Please take care of those.

1. In File, instagram_scrape.install, should have "@file" in doc comments.

/**
 * Implements hook_uninstall().
 */

2. Remove the white spaces off of file at end of file.

3. Maintain no. of characters in each line.

4. In File, instagram_scrape.module, file doc comments are missing.

5. In the same file, function doc comments seems are also missing. Please take care of it.

6. Use "/**" for function comments

There are a lots spacing and lines issues, please take care of those.

Thanks

@Collins405

Please use following code instead of <a>
$block['content']['#markup'] .= l('<img src="' . $imgurl . '" alt="' . $caption . '" />', $posturl, array('attributes' => array('target' => '_blank'), 'html' => true));

I noticed you forgot some spaces after colons in your css files. (Lines 9, 96, 97, 98, 114)
For Example:

.instagram-row {
  float: left;
  position: relative;
  overflow: hidden;
  margin:0 1% -7px 1%;
}

Also I'm wondering why you defined the function `scrape_insta` inside the function `instagram_scrape_block_view`. I don't know if it's wrong, but I'm used to define functions all on the same level. Just wondering.

I have used this module. It is working fine for me. Code/readme all looks good to me.

+1

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.