This module provides better styles for autocomplete tags widgets using Bootstrap Tags Input and Twitter Typeahead plugins.

Supported field types

  • Term reference - Autocomplete (tagging)
  • Entity reference - Autocomplete (tags style)

Requirements

  • jQuery version >= 1.7.0

Sandbox project: https://www.drupal.org/sandbox/vladyslav_bilyi/2834408

Git clone command: git clone --branch 7.x-1.x https://git.drupal.org/sandbox/vladyslav_bilyi/2834408.git autocomplete_tags_better

Comments

belyj_vladislav created an issue. See original summary.

belyj_vladislav’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2834441

Project 2: https://www.drupal.org/node/2834438

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

belyj_vladislav’s picture

Title: [D7] Entity reference autocomplete (tags style) better » [D7] Autocomplete tags better
Issue summary: View changes
Issue tags: +term reference
belyj_vladislav’s picture

Issue summary: View changes
Status: Closed (duplicate) » Needs review
belyj_vladislav’s picture

Issue summary: View changes

change git clone command

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

m.abdulqader’s picture

Hello
please add readme file and here is my review.

Automated Review
Please fix the some basic issues suggested by paraview:
https://pareview.sh/node/391

Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
No: No README file.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Thanks.

belyj_vladislav’s picture

Hello m.abdulqader,
I added the readme file, thanks for review

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvladyslav_bilyi28344...

I'm a robot and this is an automated message from Project Applications Scraper.

belyj_vladislav’s picture

Status: Needs work » Needs review

I fixed all errors except errors in files of external libraries

m.abdulqader’s picture

Don't include the libraries file in your project and load them from libraries directory.

Regards

belyj_vladislav’s picture

But, why? If I don't want to use Libraries API for so small module. It's the normal practice put external libraries into module and use hook_library(). For example, jquery_update module.

m.abdulqader’s picture

Hello

Could you please read the 3rd party libraries and content on Drupal.org

This will help.

Regards

belyj_vladislav’s picture

Thanks for reply, I've read this article and it says that if library has a license that allows us to distribute it under GPLv2+ I can commit this library. All libraries in my module has the MIT licence, here https://www.drupal.org/node/1475972#whitelist-licenses you can see that MIT into whitelist licenses.

naiduharish’s picture

Status: Needs review » Needs work

Hi belyj_vladislav,

Below is my observation on Manual review.
1) In info file please provide proper package name.
2) Also seems that you have added your custom js "autocomplete_tags_better" in hook_library(), you can add it using "drupal_add_js".
3) External Libraries and JS are added in same folder js. You can create another folder as libraries and keep the external libraries in that.

please fix the issues and change the status to needs review.

belyj_vladislav’s picture

Hi naiduharish,

1) A package name isn't required into .info file.
2) Why do you think that I cann't add my library in this hook.
3) To my mind its a bad idea, can you explain this?

Thanks

belyj_vladislav’s picture

Status: Needs work » Needs review
belyj_vladislav’s picture

Priority: Normal » Major
belyj_vladislav’s picture

Issue tags: +taxonomy
belyj_vladislav’s picture

Status: Needs review » Closed (outdated)
avpaderno’s picture

Priority: Major » Normal
Status: Closed (outdated) » Closed (won't fix)
Issue tags: -tags, -autocomplete, -entityreference, -term reference, -widget, -style, -taxonomy