Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2016 at 21:06 UTC
Updated:
8 Sep 2018 at 19:22 UTC
Jump to comment: Most recent
Comments
Comment #2
belyj_vladislav commentedComment #3
PA robot commentedProject 1: https://www.drupal.org/node/2834441
Project 2: https://www.drupal.org/node/2834438
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
belyj_vladislav commentedComment #5
belyj_vladislav commentedComment #6
belyj_vladislav commentedchange git clone command
Comment #7
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
m.abdulqader commentedHello
please add readme file and here is my review.
Automated Review
Please fix the some basic issues suggested by paraview:
https://pareview.sh/node/391
Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: No README file.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Thanks.
Comment #9
belyj_vladislav commentedHello m.abdulqader,
I added the readme file, thanks for review
Comment #10
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxvladyslav_bilyi28344...
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #11
belyj_vladislav commentedI fixed all errors except errors in files of external libraries
Comment #12
m.abdulqader commentedDon't include the libraries file in your project and load them from libraries directory.
Regards
Comment #13
belyj_vladislav commentedBut, why? If I don't want to use Libraries API for so small module. It's the normal practice put external libraries into module and use hook_library(). For example, jquery_update module.
Comment #14
m.abdulqader commentedHello
Could you please read the 3rd party libraries and content on Drupal.org
This will help.
Regards
Comment #15
belyj_vladislav commentedThanks for reply, I've read this article and it says that if library has a license that allows us to distribute it under GPLv2+ I can commit this library. All libraries in my module has the MIT licence, here https://www.drupal.org/node/1475972#whitelist-licenses you can see that MIT into whitelist licenses.
Comment #16
naiduharish commentedHi belyj_vladislav,
Below is my observation on Manual review.
1) In info file please provide proper package name.
2) Also seems that you have added your custom js "autocomplete_tags_better" in hook_library(), you can add it using "drupal_add_js".
3) External Libraries and JS are added in same folder js. You can create another folder as libraries and keep the external libraries in that.
please fix the issues and change the status to needs review.
Comment #17
belyj_vladislav commentedHi naiduharish,
1) A package name isn't required into .info file.
2) Why do you think that I cann't add my library in this hook.
3) To my mind its a bad idea, can you explain this?
Thanks
Comment #18
belyj_vladislav commentedComment #19
belyj_vladislav commentedComment #20
belyj_vladislav commentedComment #21
belyj_vladislav commentedComment #22
avpaderno