[D7]Multiple sitemap

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Jitendra (@jitujain).

I did a code review without installing the plugin and you have to fix a few things:

1. README.txt does not adhere to the guidelines for internal documentation
2. Your module is missing a hook_help implementation.
3. Your module includes some functions that violate the naming conventions for functions:
- function max_custom_sitemap_get_content_types_links($node_type = NULL)
- function max_custom_sitemap_get_internal_sitemap_links()
- function max_custom_sitemap_get_all_menu_links()
- etc.

All function names should start with your module name multiple_sitemap_your_function, see https://www.drupal.org/node/318#naming

Regards.

uh

Hi Jitujain.

Thanks. I did an installation to see what happens and there's a problem with your sitemap generation. You should not include internal Drupal tokens as references that are meant to be substituted. <nolink> should not appear. While <front> obviously gets its path alias other tokens won't. Submitting invalid value with sitemaps is not a good idea. You have to work on functions like this one: multiple_sitemap_get_menu_links.

Regards.
uh

P.S. A small update: You should include a link to the configuration in the .info file

And to help others I place here the findings according to the manual review template:

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Check: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Should be reviewed by somebody else.

Coding style & Drupal API usage

List of identified issues in no particular order:

1. (*) Sitemap urls need to validate better to avoid 404 Errors for sitemaps @see above in this post
2. (+) Place configure link in .info file
3. Display README.md or README.txt in admin/help
4. (*) Please check if this module isn't offering what you try to implement: https://www.drupal.org/project/xmlsitemap_nodetype

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Hi @jitujain.

I've checked your code and your solution does not work at all, probably you implemented by mistake this line:

$query->condition('menu_name', $type, '<>');

But there's more to it, now you won't get paths like <front> included at all and that's a valid one. An improvement could look like this:

function multiple_sitemap_get_menu_links($menus = array()) {

  $menu_links = array();
  $i = 0;

  if (!empty($menus)) {
    foreach ($menus as $menu) {
      $type = $menu->menu_type;
      $menuvalues = menu_load_links($type);
      if (!empty($menuvalues)) {
        foreach ($menuvalues as $key => $menuvalue) {
          if (!$menuvalue['hidden']) {          
            $path = drupal_get_path_alias($menuvalue['link_path']);
            $path = url($path, array('absolute' => TRUE));
            if (!preg_match( "/(\<)(.*?)(\>)/", urldecode($path))) {            
              $menu_links[$i]['link'] = $path;
              $menu_links[$i]['priority'] = $menu->priority;
              $menu_links[$i]['changefreq'] = $menu->changefreq;
              $i++;
            }
          }
        }
      }
    }
  }
  return $menu_links;
}

Regards.
uh

Please review your code on "https://pareview.sh" site. We found some issue in your code. Here I have attached the link for your error code.

https://pareview.sh/node/18

Removing review bonus tag, you have not listed any reviews in the issue summary? Make sure to read https://www.drupal.org/node/1975228 again.

Oops, project applications are tasks.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxJitujain2805199git

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @Jitujain

Automatic Review
There are some issues about Drupal coding standards

Please fix it and run again the automatic review:
https://pareview.sh/node/18/repeat

Manual Review

I didn't found any issues , below are my manual review

Individual user account
[Yes: Follows / No: Does not follow] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause / No: Causes] module duplication and/or fragmentation.
Master Branch
[Yes: Follows / No: Does not follow] the guidelines for master branch.
Licensing
[Yes: Follows / No: Does not follow] the licensing requirements.
3rd party assets/code
[Yes: Follows / No: Does not follow] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows / No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows / No: Does not follow] the guidelines for project length and complexity.

Just a recommendation
I think, you should avoid concatenating strings in db queries, You can assign to variable instead of using directly.
For example in file includes/multiple_sitemap.db.inc

$query = db_select('multiple_sitemap_' . $record_type, 'ms');

Other line:

 ->fields(array(
            'target_ms_id' => $ms_target_id,
            $record_type . '_type' => $subrecord['name'],
            'priority' => $subrecord['priority'],
            'changefreq' => $subrecord['changefreq'],
          ))

It's not a blocker, just a tip.

Hi @Jitujain,

Your module is very useful, congratulations. I hope to see it as project soon.

I will update the status for this issue, but I think you should consider the recommendations about Drupal coding standards.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.