[D8] CountToBlock

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please add README file.

Hi kvercruyssen,
I was able to install module successfully but after that i was not able to use it,
please provide hook_help and more information o project page.
If see that module used blockForm

public function blockForm($form, FormStateInterface $form_state) {
    $form = parent::blockForm($form, $form_state);

    $config = $this->getConfiguration();

    $form['subject'] = array(
      '#type' => 'textfield',
      '#title' => $this->t('Subject'),
      '#default_value' => isset($config['subject']) ? $config['subject'] : '',
      '#description' => $this->t('The subject, like "cups of coffee" or "happy customers"'),
      '#required' => TRUE,
    );

So is there a block configuration available for this, i checked admin/structure/block, did not find there.
Please update and i will test this more.
Thanks

@vipul.patil7888: Thanks for your review! Is this now RTBC or are there application blockers left and this should be "needs work"?

Hi @kvercruyssen,
I have tried using counttoblock module, to actually know how it works and what it does. After installing, i saw there is block form you have created and so found counttoblock in the block layout. I have placed counttoblock with a settings as "Count From":0 & "Count To":10 , Placed in the content region and when i refresh my page, the block shows up counting from 0 to 10(as shown in the attached image).

-> All the CSS and Js works fine.
-> Can you please list out the few use cases where we can actually use this module along with README file, so that there will be a better understanding of the module. Once, we get understand the module, we can test it better.
-> Also please refer to Issues in pareview.sh .

1. In .module and CounttoBlock.php file consider using [] instead of array()
2. As $config['interval'] : 100 default value set to 100 in two different place in code, consider using constant or in a better way read them from yaml config file.

Please do not assign ticket yourself. Please see the workflow https://www.drupal.org/node/532400

I set this to "Reviewed & tested by the community", because just the README file is missing, but if it should be on "Needs work" just let me know.

Automated Review

https://pareview.sh/node/454 found errors in the JS files, but I see that you are aware of that.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. Please add a README file
2. Fix the errors if possible, but formatting errors shouldn't block the project's approval

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.