Issue with selections + single cardinality [#2825730]

I'm finding that if I have the widget mode set to 'Edit selection' and my field cardinality is set to 1, the 'Selections' in the modal can still display multiple files. I would expect that this not be the case.

It looks like the validation on the server doesn't really check this before just doing an array_merge to put the new selection in with the existing selections.

It is likely that the more general cardinality case wants to be solved here (i.e. cardinality > 1 and not infinite), but that's a different set of problems once you add in the prepend/append mode options etc. So I'm going to keep this ticket on track for this particular single selection problem.

Comment	File	Size	Author
#7	entity_browser-issue_with_selections-2825730-7.patch	1.06 KB	rp7
#5	issue_with_selections-2825730-5.patch	1.71 KB	amoebanath
#3	issue_with_selections-2825730-2-3-interdiff.txt	1.04 KB	amoebanath
#3	issue_with_selections-2825730-3.patch	1.57 KB	amoebanath
#2	issue_with_selections-2825730-2.patch	886 bytes	amoebanath

Issue fork entity_browser-2825730

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2825730-field-cardinality-selection-widget changes, plain diff MR !82
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

2825730-issue-with-selections

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

8 November 2016 at 13:19

amoebanath created an issue. See original summary.

Comment #2

amoebanath commented 8 November 2016 at 13:35

Assigned:	amoebanath	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	issue_with_selections-2825730-2.patch	886 bytes

Patch!

Checks if there should be a cardinality validation of 1, and, if so, replaces the previous selection with the new selection (which has already been validated as a single selection).

Comment #3

amoebanath commented 8 November 2016 at 15:09

Status	File	Size
new	issue_with_selections-2825730-3.patch	1.57 KB
new	issue_with_selections-2825730-2-3-interdiff.txt	1.04 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	issue_with_selections-2825730-2.patch	886 bytes

This seems to have brought up another issue a little further along. An easy fix, by the look of things.

Comment #4

amoebanath commented 8 November 2016 at 15:29

Assigned:

Unassigned

» amoebanath

Hmm. Maybe this isn't the quick fix I thought.
The final selection value doesn't seem to save...

Comment #5

amoebanath commented 8 November 2016 at 15:51

Status	File	Size
new	issue_with_selections-2825730-5.patch	1.71 KB

Gotcha. When you submit the modal, the selections don't quite follow the same routes. So we just need to handle that scenario by checking on $entities before handling that value.

Comment #6

marcoscano

Portuguese, Brazil

Barcelona, Spain

commented 29 May 2017 at 11:35

Status:	Needs review	» Postponed (maintainer needs more info)
Issue tags:		+D8Media

I have tried to manually reproduce the failing scenario you mention, but I am unable to do it with the current -dev.

Could you please indicate if this issue still exists, and if so, provide steps to reproduce it?

Thanks!

Comment #7

rp7 commented 10 March 2020 at 09:15

Status:

Postponed (maintainer needs more info)

» Active

Status	File	Size
new	entity_browser-issue_with_selections-2825730-7.patch	1.06 KB

@marcoscano
According to me this issue still exists.
Pre-requisites:

Have a single value field
Entity browser with views widget & multi step selection

If you select multiple items & try to add it to the selection, you will get an error message that only 1 item may be selected = OK.
Selecting 1 item & adding it to the selection works, but you can repeat this infinitely. Multiple items will be in the selection, while the field itself can only reference 1. If you submit the selection, only the first item is applied.

I see multiple solutions

Provide an error message when you try to add an item to a selection while the cardinality is already reached
Leave widget selection as is, but validate the selection cardinality when submitting the entity browser.
Allow to add as many items as you wish to the selection, but validate the selection cardinality when submitting the entity browser.

I couldn't get patch in #5 to work. Patch attached goes for solution number 2 (see above). I'm wondering if the widget validators can't be used to validate the selection as well...

Comment #8

piotr pakulski

Poland 🇪🇺

commented 20 March 2023 at 17:03

Assigned:

amoebanath

» Unassigned

Comment #9

23 June 2025 at 17:40

mdranove made their first commit to this issue’s fork.

Comment #10

23 June 2025 at 17:40

mdranove changed the visibility of the branch 2825730-issue-with-selections to hidden.

Comment #11

23 June 2025 at 17:40

mdranove changed the visibility of the branch 2825730-issue-with-selections to active.

Comment #12

23 June 2025 at 17:52

mdranove opened merge request !82

Comment #13

mdranove commented 23 June 2025 at 17:53

Status:

Active

» Needs review

I had this same issue. patch in #7 works well, looks like a clean solution. Created MR and moving to NR. I think if we want to do some js work that should be done in a separate issue.

Comment #14

anybody

German

Porta Westfalica

commented 14 August 2025 at 08:39

@mdranove thanks! Could you check if #3177204: It's possible to overflow the number of allowed items with edit selection is a duplicate or should also be fixed by the MR?
Then we could push (both) things forward. Thank you!

Comment #15

19 August 2025 at 07:13

anybody changed the visibility of the branch 2825730-issue-with-selections to hidden.

Comment #16

anybody

German

Porta Westfalica

commented 19 August 2025 at 07:32

Version:

8.x-1.x-dev

» 8.x-2.x-dev

Comment #17

anybody

German

Porta Westfalica

commented 20 August 2025 at 13:00

Parent issue:

» #3542234: [META] Add a setting to only allow unique selection

Comment #18

mdranove commented 21 August 2025 at 17:57

Hi @anybody.

Yes looks like #3177204: It's possible to overflow the number of allowed items with edit selection is a duplicate issue, although the proposed resolution is different than what is done here. I tried the patch provided in the ticket and it throws an exception on my Drupal 10.2,

I recommend moving forward with this MR.

Comment #19

benstallings commented 8 April 2026 at 20:06

Status:

Needs review

» Needs work

Needs merge conflicts resolved.

Comment #20

benstallings commented 29 April 2026 at 20:23

Assigned:

Unassigned

» benstallings

Comment #21

benstallings commented 29 April 2026 at 20:30

Assigned:	benstallings	» Unassigned
Status:	Needs work	» Needs review

Comment #22

anybody

German

Porta Westfalica

commented 30 April 2026 at 06:19

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

Thanks!! I think it would make a lot of sense to have tests around this now.

Comment #23

benstallings commented 30 April 2026 at 13:51

Assigned:

Unassigned

» benstallings

Comment #24

benstallings commented 30 April 2026 at 14:14

Assigned:	benstallings	» Unassigned
Status:	Needs work	» Needs review

New test: CardinalityTest::testSelectionDisplayCardinality().

Targets the new code path specifically rather than retesting the widget-level validator. Setup: cardinality-2 entity_reference field on article, wired to the bundle_filter browser (multi_step_display) in SELECTION_MODE_APPEND. The test selects three nodes one-at-a-time — each press is a single-entity batch that the widget-level Cardinality validator passes, but selected_entities grows to 3. Pressing "Use selected" then has to be rejected by SelectionDisplayBase::validate(); nothing else in the validation stack can catch it. Asserts the "You can only select up to 2 items" error.