[D8] Bulk Image Uploader And Compressor

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I have tested your module and found out that while the .zip file is uploaded and the form is submitted. The directory is created but the success message coming on the front is "image is not jpg hence not uploaded."

The images are JPG only but after running it is saying that it's not which is also not uploaded. Whereas I can see the folder under my directory.

Suggestion: If the same name zip file is uploaded again then there must be an option to confirm whether to replace or not?

@arshadkhan35

1. pareview.sh gives some errors.

https://pareview.sh/node/1183

2. image_upload.module is empty. you can remove it.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Arshad Khan,

Automated Review

Minor suggestion from automation review :

• Git default branch is not set, see the documentation on setting a default branch.([#1659588])

Manual Review

Individual user account

[Yes: Follows ]

No duplication

No

Master Branch

No

Licensing

Yes

3rd party assets/code

Yes Follows.

README.txt/README.md

Not as per the drupal.org guidelines. Please refer the guidelines https://www.drupal.org/node/2181737.

Code long/complex enough for review

Yes

Secure code

Yes

Coding style & Drupal API usage

1. Module package name is 'custom'. It should be so generic, it should be relavent to module functionality
2. submitForm method in UploadInterface class have duplicate docblock.
3. Helper method compressImage can be created a services. Please refer https://www.drupal.org/docs/8/api/services-and-dependency-injection/serv...

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

Hi Arshad,

Collect your review bouns to fast forward module review process.

More information : https://www.drupal.org/node/1975228

Thanks

Please refer comment #13 for collecting your review bouns.

Hello Arshad,
Kindly fix the below issue.

Manual Review

Individual user account

[Yes: Follows ]

No duplication

No

Master Branch

[Yes: Follows]

Licensing

[Yes: Follows]

3rd party assets/code

[Yes: Follows]

README.txt/README.md

[Yes: Follows].

Code long/complex enough for review

[Yes: Follows]

Secure code

[No]

Coding style & Drupal API usage

1. In file bulk_image_upload_and_compressor/src/CompressImages.php
a) Correct the Spelling for word service

/**
 * Contains sercvice for compressing, jpg image size.
 */

b) Replace deperecated function drupal_unlink.
https://api.drupal.org/api/drupal/core%21includes%21file.inc/function/dr...
c) drupal_set_message is not used as correctly. Use placeholder, don't use direct code in function.
https://api.drupal.org/api/drupal/core%21includes%21file.inc/function/dr...

      drupal_unlink($source_url);
      $exploded_img = explode('/', $source_url);
      drupal_set_message($exploded_img[count($exploded_img) - 1] . $this->t('Image is not jpg hence not uploaded.'), 'status');

2. In file bulk_image_upload_and_compressor/image_upload.routing.yml, you have created 2 routs. I checked the code in those files they are showing the same form. Whats the use creating 2 routs for the same form??

3. Getting access denied for URL http://localhost-drupal8/img_content

4. There is no validation is set in the form. see the attached files.

5. In file bulk_image_upload_and_compressor/src/Form/UploadInterface.php
a. replace the deprecated mkdir with
https://api.drupal.org/api/drupal/core!lib!Drupal!Core!File!FileSystem.p...
b. replace the deprecated drupal_realpath with https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21File%21Fi...
c. replace the deprecated drupal_unlink with https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21File%21Fi...

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.