This module provides a bridge between Drupal and Kiyoh XML API.
(https://www.kiyoh.nl/)

https://www.drupal.org/sandbox/junkuncz/2811021
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/junkuncz/2811021.git kiyoh

Comments

junkuncz created an issue. See original summary.

3ssom’s picture

Hello junkuncz,

you have to edit you link of the git repo ,, this one is for you as a maintainer ,, uncheck Maintainer? then hit the Show button .. you'll see the right one there .. edit it here.

Thank you

PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2819693

Project 2: https://www.drupal.org/node/2755901

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Jitujain’s picture

Issue summary: View changes
Jitujain’s picture

Status: Needs review » Needs work

Hi junkuncz

Manual Review

Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Also delete kiyoh_id variable while uninstalling the module.

The starred items (*) are fairly big issues and warrant going back to Needs Work.

visabhishek’s picture

Hi Jitujain,

Good catch, But its better if you will use Project Application Review Template for your review points.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.