[D7] Project version

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello MerryHamster,

Automated Review

found some errors @pareview:
http://pareview.sh/pareview/httpgitdrupalorgsandboxmbodalova2790129git

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows / No: Does not follow] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) once I enabled your module I got this:
   

   Error message
   Notice: Undefined variable: requirements in project_version_requirements() (line 50 of sites/all/modules/project_version/project_version.install).

2. (+) in your file project_version.admin.inc line:112 .. the link will end up wrong after submitting the form like this in my case .. with clean URL not enabled: (http://sandbox.dev/'/admin/reports/status/') which is even wrong path! I suggest you use l() instead ,, it will handle it will.
3. Implement hook_help().
4. Readme file needs some enhancement see the guideline for README files above!

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello.

Automatic review

OK.

Manual review:

All ok except mentioned by @3ssom

(+) in your file project_version.admin.inc line:112 .. the link will end up wrong after submitting the form like this in my case .. with clean URL not enabled: (http://sandbox.dev/'/admin/reports/status/') which is even wrong path! I suggest you use l() instead ,, it will handle it will.

Checked. Last issues were fixed.

Removing "PAReview: Single project promote" as Code long/complex enough for review.
@klausi : Please Add the tag if i am wrong.

@MerryHamster: i am not able set the Project version from first line of file. Please see the attached screenshot.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@visabhishek. I believe it is because you set absolute path and it might not be supported. Did you try using relative path?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.