Description

This is a basic implementation of the CKEditor Find/Replace plugin for Drupal 8. You can see the CKEditor plugin page here: http://ckeditor.com/addon/find

The module's plugin provides buttons that show a find or replace dialog in CKEditor. This can be used to search or replace text within the context of that editor.

Project Page

https://www.drupal.org/sandbox/dhansen/2814077

Git Clone Command

git clone --branch 8.x-1.x https://git.drupal.org/sandbox/dhansen/2814077.git ckeditor_find

Previous Project Applications

None. This is my first time trying to promote out of a sandbox.

Notes

This project is nearly identical to https://www.drupal.org/project/anchor_link except it provides a different CKEditor plugin.

Comments

dhansen created an issue. See original summary.

dhansen’s picture

dhansen commented
Issue summary: View changes
PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

dhansen’s picture

dhansen commented
Issue summary: View changes

This project previously had licensed code in it, which I've removed and put in an external library. Additionally I've put it through the automated process and it is now coming out clean.

johnpitcairn’s picture

johnpitcairn commented

Automated Review

No issues identified. https://pareview.sh/node/483

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. The guidelines suggest that the README should reproduce the project page, including installation/configuration.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity. The module code is about 10 lines short, though personally I find this requirement ridiculous.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
[List of identified issues in no particular order.
  1. (+) Should the text generated in hook_help() all be run through t()? Alternately load and return the README file as per the example in the guidelines?

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Reviewed & tested by the community

I don't think there's anything here that should block release, though some attention to the README file and help output would be good.

Similarly, to provide a CKeditor plugin this is all the code that is required, ie there will be a lot of plugins under the 120-line threshold, and I see no reason to impose that requirement on this one.

There is a display problem with the plugin window checkboxes in the Seven admin theme, but that would be a bug report not a blocker. The plugin works.

dhansen’s picture

dhansen commented
Status: Reviewed & tested by the community » Fixed

Was able to self-promote. Module is now available at https://www.drupal.org/project/ckeditor_find. Thanks for you time for reviewing!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Fixed » Reviewed & tested by the community

I assume you still want this reviewed to get security team support?

dhansen’s picture

dhansen commented

Absolutely! When I closed the ticket I did not realize that the queue's purpose had been changed over.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.