Description
This is a basic implementation of the CKEditor Find/Replace plugin for Drupal 8. You can see the CKEditor plugin page here: http://ckeditor.com/addon/find
The module's plugin provides buttons that show a find or replace dialog in CKEditor. This can be used to search or replace text within the context of that editor.
Project Page
https://www.drupal.org/sandbox/dhansen/2814077
Git Clone Command
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/dhansen/2814077.git ckeditor_find
Previous Project Applications
None. This is my first time trying to promote out of a sandbox.
Notes
This project is nearly identical to https://www.drupal.org/project/anchor_link except it provides a different CKEditor plugin.
Comments
Comment #2
dhansen CreditAttribution: dhansen at Sevaa Group commentedComment #3
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
dhansen CreditAttribution: dhansen at Sevaa Group commentedThis project previously had licensed code in it, which I've removed and put in an external library. Additionally I've put it through the automated process and it is now coming out clean.
Comment #5
John Pitcairn CreditAttribution: John Pitcairn commentedAutomated Review
No issues identified. https://pareview.sh/node/483
Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.
Manual Review
hook_help()
all be run throught()
? Alternately load and return the README file as per the example in the guidelines?The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #6
John Pitcairn CreditAttribution: John Pitcairn commentedI don't think there's anything here that should block release, though some attention to the README file and help output would be good.
Similarly, to provide a CKeditor plugin this is all the code that is required, ie there will be a lot of plugins under the 120-line threshold, and I see no reason to impose that requirement on this one.
There is a display problem with the plugin window checkboxes in the Seven admin theme, but that would be a bug report not a blocker. The plugin works.
Comment #7
dhansen CreditAttribution: dhansen at Sevaa Group commentedWas able to self-promote. Module is now available at https://www.drupal.org/project/ckeditor_find. Thanks for you time for reviewing!
Comment #8
klausiI assume you still want this reviewed to get security team support?
Comment #9
dhansen CreditAttribution: dhansen at Sevaa Group commentedAbsolutely! When I closed the ticket I did not realize that the queue's purpose had been changed over.
Comment #10
apadernoThank you for your contribution!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks go the dedicated reviewer(s) as well.
Comment #11
apaderno