[D8] Custom Metatags

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2803261

Project 2: https://www.drupal.org/node/2803167

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review:
- In the .install file, you are using entityManager service, which is deprecated. Use entityTypeManager instead.

Hi @jkamizato,

In .module file you can use hook_page_attachments instead of hook_preprocess_html as hook_page_attachments hook is used to Add attachments (typically assets) to a page before it is rendered.

@icurk and @pen: those are nice tips for improvements, but surely not application blockers. Anything else that you found or should this be RTBC instead?

Removed review links from the issue summary because those are not reviews of other project applications. See https://www.drupal.org/node/1975228

To the reviewers: Please change back the priority to Normal after doing a review.

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-custom_metatag...

Git errors:

The following git branches do not match the release branch pattern, you should remove/rename them.

Review of the 8.x-1.x branch (commit 80d5fa3):

• Your README.txt does not follow best practices (headings need to be uppercase).
• The custom_metatags.module does not implement hook_help().
• DrupalPractice has found some issues with your code, but could be false positives.
• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Possibly: Causes module duplication and/or fragmentation.
https://www.drupal.org/project/custom_meta ?

Master Branch

No: Does not follow the guidelines for master branch. Branches should have a x in the module version e.g. 1.x. Only Tags use numers like 1.0

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview details

Code long/complex enough for review

Not yet: Follows the guidelines for project length and complexity. Implement hook_help() and you should be beyond 120 lines

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) entityManager service should be replaced: EntityManager has been split into 11 classes: https://www.drupal.org/node/2549139

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.