Replace usage of t() in plugins with $this->t()

Thanks for this. There are a lot of out of scope changes in this patch. Make sure you only touch lines of code that replace t() with $this->t(), eg

1. +++ b/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimeCustomFormatter.php
   @@ -15,7 +15,7 @@
   - *)
   + * )
   

   Out of scope.

2. +++ b/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimeFormatterBase.php
   @@ -12,7 +12,6 @@
   -
   

   Out of scope.

3. +++ b/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimePlainFormatter.php
   @@ -14,7 +14,7 @@
   - *)
   + * )
   

   Out of scope.

4. +++ b/core/modules/datetime/src/Plugin/Field/FieldType/DateTimeFieldItemList.php
   @@ -34,26 +34,26 @@ public function defaultValuesForm(array &$form, FormStateInterface $form_state)
   -            )
   -          )
   -        )
   +            ),
   +          ),
   +        ),
   

   Out of scope.

5. +++ b/core/modules/datetime/src/Plugin/Field/FieldType/DateTimeFieldItemList.php
   @@ -104,7 +104,7 @@ public static function processDefaultValue($default_value, FieldableEntityInterf
   -        )
   +        ),
   

   Out of scope.

6. +++ b/core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeWidgetBase.php
   @@ -22,7 +22,6 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
   -
        $element['#theme_wrappers'][] = 'datetime_wrapper';
   

   Out of scope.

7. +++ b/core/modules/datetime/src/Plugin/views/filter/Date.php
   @@ -95,8 +95,6 @@ protected function opBetween($field) {
   -
   -
        // Convert to ISO format and format for query. UTC timezone is used since
   

   Out of scope.

8. +++ b/core/modules/datetime/src/Tests/DateTestBase.php
   @@ -59,7 +59,7 @@
   -    // UTC-11, no DST
   +    // UTC-11, no DST.
   

   Out of scope.

9. +++ b/core/modules/datetime/src/Tests/DateTestBase.php
   @@ -67,7 +67,7 @@
   -    // UTC+12, no DST
   +    // UTC+12, no DST.
   

   Out of scope.

10. +++ b/core/modules/datetime/src/Tests/DateTimeFieldTest.php
    @@ -161,7 +161,7 @@ function testDateField() {
    -        '@interval' => $this->dateFormatter->formatTimeDiffSince($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']])
    +        '@interval' => $this->dateFormatter->formatTimeDiffSince($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']]),
    
    @@ -182,7 +182,7 @@ function testDateField() {
    -        '@interval' => $this->dateFormatter->formatTimeDiffUntil($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']])
    +        '@interval' => $this->dateFormatter->formatTimeDiffUntil($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']]),
           ]);
    

    Out of scope.

11. +++ b/core/modules/datetime/src/Tests/DateTimeFieldTest.php
    @@ -182,7 +182,7 @@ function testDateField() {
    -        '@interval' => $this->dateFormatter->formatTimeDiffUntil($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']])
    +        '@interval' => $this->dateFormatter->formatTimeDiffUntil($timestamp, ['granularity' => $this->displayOptions['settings']['granularity']]),
    

    Out of scope.

There are a bunch more. While these aren't necessarily wrong changes, we try to limit the scope of an issue to fix a single thing. This helps when we have to revert something, and when we have to rebase/reroll in-progress patches when patches get committed.

Edit, I would also poke through the issue queue to see if there is a general issue about doing this throughout core. I seem to recall one, but I am not sure.

+++ b/core/modules/datetime_range/src/Plugin/Field/FieldType/DateRangeItem.php
@@ -33,23 +33,23 @@ class DateRangeItem extends DateTimeItem {
diff --git a/sites/default/default.services.yml b/sites/default/default.services.yml

diff --git a/sites/default/default.services.yml b/sites/default/default.services.yml
old mode 100644
new mode 100755
diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php

diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php
old mode 100644
new mode 100755

Out of Scope.

I have rerolled the patch removing out of scope items.

probably not a bug report :)

+++ b/core/modules/datetime_range/src/Plugin/Field/FieldType/DateRangeItem.php
@@ -33,23 +33,23 @@ class DateRangeItem extends DateTimeItem {
   public static function propertyDefinitions(FieldStorageDefinitionInterface $field_definition) {
     $properties['value'] = DataDefinition::create('datetime_iso8601')
-      ->setLabel(t('Start date value'))
+      ->setLabel($this->t('Start date value'))
       ->setRequired(TRUE);
 

My suspicion is most of the fails are caused around here. If you look at the test results, there are a lot of "PHP Fatal error: Using $this when not in object context". This is a static function, so you can't use $this here. `static::t()` would be the proper thing to do, however, the only place in core where we use this is Views::getHandlerTypes(). From a quick look at other items (eg, BooleanItem), we use $this->t() in normal methods, but t() in static ones.

Thanks, I will try to look at this tonight. When posting new work on an issue, adding a interdiff, so everyone can see both the new patch and what has changed since the last version. Here is the one between #10 and #14. Personally, I prefer the branch-per-patch method of working, so I use the git method.

I'm working on it at DrupalConEur Dublin Sprint

I am helping @condor616 with this issue as a mentor.

In the DateTimeDatelistWidget.php file, the function settingsForm() still contains t() instead of $this->t()

$element['increment'] = [
        '#type' => 'select',
        '#title' => t('Time increments'),
        '#default_value' => $this->getSetting('increment'),
        '#options' => [
          1 => $this->t('1 minute'),
          5 => $this->t('5 minute'),
          10 => $this->t('10 minute'),
          15 => $this->t('15 minute'),
          30 => $this->t('30 minute'),
        ],
      ];

I fixed the issues reported in #19. Please review

I helped @condor616 with this issue as a mentor as well.

Doing some housekeeping here.

Replacing t() with $this->t() is the proper thing to do for the long term health of Drupal, but limiting this to just the datetime module isn't the right thing to do (see https://twitter.com/xjmdrupal/status/784386236370878465 and https://www.drupal.org/core/scope).

I don't know if there are long term plans to do this globally to the codebase as a mega-patch or a series of issues, but I am punting this over to the language system.

Thanks to all who helped work on this. This has become outdated. It was fixed in #3181778: [w/c September 17th] Replace t() with $this->t() in all plugins.