Problem/Motivation

When we change protocol we change default port number, but when we check SSL checkbox the port number is not changing.

Proposed resolution

When SSL is change, update port number. Maybe to use JS fot updating value.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 change_port_number_when-2799857-3.patch1.21 KBtoncic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toncic92 created an issue. See original summary.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Issue tags: +Usability

Yeah that's a healthy UX improvement.
But with much higher priority, i would want to be able to trigger message processing in the UI, see their process and have feasible logging in place and also have a UI for the mail itself.

toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Assigned: Unassigned » toncic
Status: Active » Needs review
FileSize
change_port_number_when-2799857-3.patch1.21 KB

This patch is not working. I can not attached my custom js. @Berdir say to upload patch and he will take a look.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/inmail.libraries.yml
@@ -0,0 +1,6 @@
+  dependency:
+    -core/jquery

Not sure if is the only problem, but it should be dependencies and one space after -.

+++ b/src/Plugin/inmail/Deliverer/ImapFetcher.php
@@ -254,6 +254,9 @@ class ImapFetcher extends FetcherBase implements ContainerFactoryPluginInterface
+      '#attached' => [
+        'library' => ['inmail/inmail'],
+      ]

The IMAP fetcher is a plugin and the IMAP configuration form is build on an ajax request.
I guess this won't rebuild the libraries in that case?