Closed (fixed)
Project:
Image Effects
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Sep 2016 at 00:07 UTC
Updated:
5 Oct 2016 at 08:44 UTC
Jump to comment: Most recent
Comments
Comment #2
karlsheaComment #3
mondrakeThanks for the report.
I believe this is strictly connected with #2784703: Branch tests broken.
Something must have happened in Drupal core since the module was working and passing tests OK at least until end of June, then a patch test on July 31 failed: https://www.drupal.org/pift-ci-job/428235, with failures unrelated to the patch.
That one was resolved by adding a test_dependency to ImageMagick so tests can rely on that module being installed.
Maybe this is pointing to the root cause?
Comment #4
mondrakeI suspect the problem comes from the commit of Drupal core #2763157: Allow plugins to provide multiple forms, specifically from this hunk
is_subclass_of($definition['class'], PluginFormInterface::class))probably needs to load the class specified by$definition['class']. Since thisAutoOrientis a subclass ofDrupal\imagemagick\Plugin\ImageToolkit\Operation\imagemagick\ImagemagickImageToolkitOperationBase, and that class is not available as it's from a not installed module, this fails.Is the module working on Drupal 8.1.x where the above was not committed?
Comment #5
berdirWe could open a core bug about this, this is clearly a regression.
Other modules had this too, e.g. search_api and they moved dependant classes into an optional submodule.
Comment #6
mondrakeOK I will log an issue in core's queue.
Comment #7
mondrakeOpened #2796953: [regression] Plugins extending from classes of uninstalled modules lead to fatal error during discovery.
Comment #8
mondrakeThis issue should be fixed in core with Drupal 8.2.0-rc2 release, due out soon. Marking as fixed, please reopen if not.
For Image Effects module, a follow-up is #2799867: Skip discovery of ImageToolkitOperations for which the relative toolkit is not installed, which has a patch already. Reviews appreciated.