Comments

mondrake created an issue. See original summary.

mondrake’s picture

Priority: Major » Critical
Status: Active » Needs review
StatusFileSize
new1.32 KB

Locally tests pass, so let's do some debugging to see where this fails on CI

Status: Needs review » Needs work

The last submitted patch, 2: 2784703-2.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.39 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2784703-4.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new500 bytes

Status: Needs review » Needs work

The last submitted patch, 6: 2784703-6.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new828 bytes

Status: Needs review » Needs work

The last submitted patch, 8: 2784703-8.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new723 bytes

Status: Needs review » Needs work

The last submitted patch, 10: 2784703-10.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.96 KB

Status: Needs review » Needs work

The last submitted patch, 12: 2784703-12.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.53 KB

Status: Needs review » Needs work

The last submitted patch, 14: 2784703-14.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new2.53 KB
mondrake’s picture

StatusFileSize
new2.8 KB

The last submitted patch, 16: 2784703-16.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 17: 2784703-17.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new51.72 KB

Status: Needs review » Needs work

The last submitted patch, 20: 2784703-20.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new52.26 KB
mondrake’s picture

StatusFileSize
new52.02 KB

Status: Needs review » Needs work

The last submitted patch, 23: 2784703-23.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new52.27 KB

Status: Needs review » Needs work

The last submitted patch, 25: 2784703-25.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new52.28 KB

Status: Needs review » Needs work

The last submitted patch, 27: 2784703-27.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new51.45 KB
mondrake’s picture

StatusFileSize
new51.45 KB

The last submitted patch, 29: 2784703-29.patch, failed testing.

mondrake’s picture

StatusFileSize
new4.06 KB

Status: Needs review » Needs work

The last submitted patch, 32: 2784703-31.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.11 KB

Status: Needs review » Needs work

The last submitted patch, 34: 2784703-34.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new4.87 KB

Status: Needs review » Needs work

The last submitted patch, 36: 2784703-36.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new4.87 KB

Status: Needs review » Needs work

The last submitted patch, 38: 2784703-38.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new4.92 KB

Status: Needs review » Needs work

The last submitted patch, 40: 2784703-40.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new5.96 KB

Status: Needs review » Needs work

The last submitted patch, 42: 2784703-42.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new8.02 KB

Status: Needs review » Needs work

The last submitted patch, 44: 2784703-44.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new8.05 KB

Status: Needs review » Needs work

The last submitted patch, 46: 2784703-46.patch, failed testing.

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.4 KB

In the end, it looks like it was sufficient to add a test_dependency to 'imagemagick' in the .info.yml file.

See http://cgit.drupalcode.org/image_effects/commit/?id=c6ee646.

Some of the work in #46 could be useful if converting the test suite to KernelTests.

Patch here would just fix a couple of minor things.

  • mondrake committed efa2101 on 8.x-1.x
    Issue #2784703 by mondrake: Branch tests broken
    
mondrake’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.