Problem/Motivation

Disabled fields should have special styles to imply its state. Currently form-autocomplete, form-date and form-time fields are missing these styles.

Proposed resolution

Add disabled state specific styles for these elements.

Remaining tasks

  • Create a patch fixing the bug
  • Take screenshots

User interface changes

-

API changes

-

Data model changes

CommentFileSizeAuthor
#9 2791459-after-#4.png105.94 KBjustanothermark
#9 2791459-before-#4.png99.87 KBjustanothermark
#4 seven-disabled_date_grey_out-2791459-3-D8.patch494 bytessinn
#3 seven-disabled_date_grey_out-2791459-3-D8.patch494 bytessinn

Issue fork seven-2791459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sinn created an issue. See original summary.

sinn’s picture

sinn commented
Issue summary: View changes
sinn’s picture

sinn commented
StatusFileSize
new seven-disabled_date_grey_out-2791459-3-D8.patch494 bytes

Patch is attached

sinn’s picture

sinn commented
Status: Active » Needs review
StatusFileSize
new seven-disabled_date_grey_out-2791459-3-D8.patch494 bytes

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

justanothermark’s picture

justanothermark commented
Status: Needs review » Reviewed & tested by the community

I can confirm that this is still an issue and that the patch still applies and fixes it. Although I'm the only reviewer so far, given the simplicity of the fix I am inclined to mark it as RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots

@justanothermark or anyone it'd be great if there was before and after screenshots so that a committer can review the patch with confidence that it is has been reviewed and tested by the community. This is especially true when the patch has no automated tests.

justanothermark’s picture

justanothermark commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots
StatusFileSize
new 2791459-before-#4.png99.87 KB
new 2791459-after-#4.png105.94 KB

Before & after screenshots attached.

cilefen’s picture

cilefen commented
Title: Disabled date field have to be grey out » Disabled date fields have to be greyed out
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs followup

So this fixes the issue in Seven; has anyone checked whether the bug applies to Bartik as well? Is there any module-level CSS for this (I guess it would be from System module)?

The need to add this specifically also makes me wonder why we do not have a more general CSS rule for this; it seems like we could keep having this bug exposed in other input elements.

I do think this is okay to backport to 8.3.x since:

  • It's clearly a bug with usability and accessibility impact
  • The only visual change is fixing the bug
  • It's applying an existing CSS rule to an element that was missed as an oversight
  • It's for an internal core theme and doesn't disrupt base themes.

My question about whether we need more general CSS could be addressed in a followup if the frontend framework managers agree, since that would be more potentially disruptive. That way the bugfix can go in and we can follow up further for improving the CSS if appropriate.

I do think we should check Bartik before commit. Leaving at RTBC for the frontend framework managers though.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Disabled date fields have to be greyed out » Disabled date fields should be greyed out like other disabled fields
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Disabled date fields should be greyed out like other disabled fields » Some disabled fields are missing disabled state specific styles
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Thanks for everyone working on the issue and @xjm for the review.

This issue does not exist in Bartik since the implementation is slightly different there. We also don't have disabled styles in system module since it purely relies on the browser default styles. This problem exists in Seven because it overrides the styles provided by the browser.

However, what I found out while reviewing this with @Cottser was that form-autocomplete and form-time are missing these styles as well. I think we should expand the scope here and fix it once for all input types.

We should open up a follow-up for improving form element classes so that this could be fixed in a less fragile way.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Project: Drupal core » Seven
Version: 9.5.x-dev » 1.0.0-alpha1
Component: Seven theme » Code

Asked in $bugsmash about this. mstrelan checked that this is not an issue for Claro and based on #13 this can go to the contrib project.

Thanks.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.0.0-alpha1 » 1.0.x-dev
Issue tags: -Needs followup +Needs merge request
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +CSS

avpaderno opened merge request !76

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs work » Needs review
Issue tags: -Needs merge request
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned
Status: Needs review » Reviewed & tested by the community

  • avpaderno committed 9f4fc821 on 1.0.x 
    Issue #2791459: Some disabled fields are missing disabled state specific...

  • avpaderno committed 807184b5 on 2.0.x 
    Issue #2791459: Some disabled fields are missing disabled state specific...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
xjm’s picture

xjm
she/her
Primary language English
commented

Amending attribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.