I faced many issues with the module and found many patches to fix but cannot apply all patches due to missing ones which are not in the last or dev version.

The module needs his maintainer to review and commit the patches, for example, I wrote a simple patch to add Drush command to import content instead of disabling and enable the module and to bypass not imported during installation

CommentFileSizeAuthor
#16 import_from_module-2783861-16.patch944 bytesyogeshmpawar
#8 import_from_module.patch1.08 KBmhmd
import_from_module.patch876 bytesmhmd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mhmd created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Active » Postponed (maintainer needs more info)

There are no patches RTBC https://www.drupal.org/project/issues/default_content?status=14 so I'm not sure what you mean by 'The module needs his maintainer to review and commit the patches'. The module is a key plank of the agov install profile and is working as expected, with test coverage.

So is this a new issue/feature or a duplicate of an existing one?

Also, I find your tone offensive, we're all volunteers.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Priority: Major » Normal

Support requests cannot be major see https://www.drupal.org/node/45111#major

mhmd’s picture

mhmd CreditAttribution: mhmd as a volunteer and commented

Dear Larowlan,

I appreciate the work it's very good and we are all (the community) benefit from it, I am sorry if my words were offensive.
I mean that I found old patches for feature and support requests that give errors when I used them as I need to contribute to the module.

the issues that needs review are:
- The module does not import when to install drupal despite being enabled so I have to disable and enable it again in order to work and import happen.
- The module imports the previously imported content before

Feature requests are :
- Simple drush command to import new content.
- Exported content to be put in /content not in the root for the project.

I realized that many patches date after the last dev version, So we could review patches and commit to the module or the dev version,
If something wrong please let me know.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Ah, so if the patches no longer apply, they need to be re-rolled..

In terms of issues that need review, that doesn't need the maintainer. Anyone can review.

If you review it and it solves your problem - and you're happy with the code, please change the status to 'Review and tested by community', that's the point from which it gets committed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Title: Patched issues not committed to the module » Add command to import from a module
Category: Support request » Feature request
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Release blocker

Thanks for your contribution - new title to reflect what this command provides.

Status: Needs review » Needs work

The last submitted patch, import_from_module.patch, failed testing.

mhmd’s picture

mhmd CreditAttribution: mhmd as a volunteer and commented
FileSize
import_from_module.patch1.08 KB

New patch works fine with git apply from the module directory

The last submitted patch, import_from_module.patch, failed testing.

The last submitted patch, import_from_module.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: import_from_module.patch, failed testing.

yannisc’s picture

yannisc CreditAttribution: yannisc at Netstudio commented
Status: Needs work » Reviewed & tested by the community

#8 worked for me.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The last submitted patch, 8: import_from_module.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
import_from_module-2783861-16.patch944 bytes

I have rerolled the patch & its working for me.

keesje’s picture

keesje CreditAttribution: keesje commented
Status: Needs review » Needs work

Powerfull feature with potential to open up a can of worms.
Tested #16 and works the first time. If any of the imported entities already exists, or another entity with the same ID an error "Integrity constraint violation: 1062 Duplicate entry" occurs.
default_content_modules_installed() is designed to run once at installation, there is no check on existing entities. We need a way to update existing entities. How? overwrite and resave? skip? Could be a slippery slope if this is used for nodes with revisions an/or entities with relations to other entities. Existing "lower" entities like paragraphs could easily become orphaned. And what about deletion of previously imported and now removed entities? Maybe this module is not designed for keeping things in sync.

keesje’s picture

keesje CreditAttribution: keesje commented

ouch, this is probly a duplicate of https://www.drupal.org/node/2640734...

ao2’s picture

ao2 CreditAttribution: ao2 as a volunteer commented
Status: Needs work » Closed (duplicate)
Related issues: +#2640734: Allow manual imports

I am going through the issue queue and this really looks like a duplicate of #2640734: Allow manual imports, so I am closing it, I hope the maintainer doesn't mind.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

yep, let's focus on that issue!