[D7] Migration 6 to 7 Keep user password same

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2766739

Project 2: https://www.drupal.org/node/2650052

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Joshua,

Please see a code review below:

1. In .module file, when setting #default_value of "migration_6_to_7_keep_user_password_same_enable_disable_user_old_password" field you're passing 2nd argument wrong. It should be 0/1 instead of "migration_6_to_7_keep_user_password_same_form".
2. Please update function comment for "migration_6_to_7_keep_user_password_same_user_authenticate" function, as this is not a hook_user_login implementation.
3. There is no variable like "password_inc" in variable table, you can directly load password.inc file using "require_once DRUPAL_ROOT . '/includes/password.inc';"
4. README.md or README.txt is missing, see the guidelines for in-project documentation. - Copied from pareview.sh

NOTE: You don't need to include everything in your module name, you can keep your module name simple and short. And all other details about your module and its functionality can be later added in project page.

PA Robot closed the wrong project. This project (Project 1: https://www.drupal.org/node/2766739) is too small, while the other project (Project 2: https://www.drupal.org/node/2650052) is of sufficient length and has already been worked on for some time now - that is the one that should be reviewed unless the project owner chooses otherwise.

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

This is the right status.