[D7] Payeezy Gateway for Ubercart

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjoshua12345112649314git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@joshua1234511: When you fix things you should set the status back to "Needs review" so people know to take a look at your project again ...

In general I think this looks good. Some things to note:
1) You don't need hook_update_last_removed(), and in fact it returns the wrong thing in your case.
2) When deleting variables in hook_uninstall(), you should delete them individually by name, not with a LIKE.
3) You left some personal information in $merchant_ref.
4) I strongly suggest you get rid of the inner functions and make them into regular functions. Using inner functions in this manner just makes your code more difficult to read and maintain, and there is absolutely no advantage to be gained over regular functions in this case.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

This issue is not fixed? See the workflow https://www.drupal.org/node/532400

Hi joshua1234511,

Online Review

: http://pareview.sh/pareview/httpgitdrupalorgsandboxjoshua12345112649314git

Manual Review:

• Follow the Readme template for the readme.txt https://www.drupal.org/node/2181737
• It is suggested keep only the hook implementations in the .module file and move other functions to a inc file ie :
• function payeezy_gateway_for_ubercart_charge
• function process_input
• function set_primary_tx_pay_load
• function get_pay_load
• function _payeezy_gateway_for_ubercart_cvv

Leave a blank line before adding a function ie

}
/**
 * Returns the message text for a CVV match.
 */
function _payeezy_gateway_for_ubercart_cvv($code) {

TO

}

/**
 * Returns the message text for a CVV match.
 */
function _payeezy_gateway_for_ubercart_cvv($code) {

@visabhishek: Those issues you raised are not project blockers, so the status should not be set back to needs work. If the project is good other than coding standards issues and other minor things, then you should set it to RTBC.

Regarding the .inc file, in this case it is NOT recommended. First because three of those functions are inner functions, and therefore by definition must be placed in the body of the outer function (which is in .module). Also, payeezy_gateway_for_ubercart_charge() must be in the .module file for the hook to find it, and __payeezy_gateway_for_ubercart_cvv() is called from payeezy_gateway_for_ubercart_charge() and it is much more efficient and easier to understand if it is in the same file (especially because it's only a few lines of code), rather than having to load a .inc every single time. The idea of putting functions into an include file pertains mainly to administrative forms and functions, which are not needed most of the time therefore shouldn't be loaded into memory on every page request. That's not the case here. If you have to load the .inc on every page request, then you're not saving anything, you're making it worse.

In #4 I raised the issue of inner functions and said they should be avoided. That's not a blocker either, but clearly visabhishek thought they were stand-alone functions, which demonstrates that these constructs can be confusing.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2766739

Project 2: https://www.drupal.org/node/2650052

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA Robot closed the wrong project. The other project (Project 1: https://www.drupal.org/node/2766739) is too small, while this project (Project 2: https://www.drupal.org/node/2650052) is of sufficient length and has already been worked on for some time now - this is the one that should be reviewed unless the project owner chooses otherwise.

From the project application guidelines, this application should have been set to critical priority a long time ago:
Critical: Applications with a status of needs review that have been awaiting response from a reviewer for 4+ weeks.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Tested functionality
Checked code against coding standards
All looks good.Changed to RTBC.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.