Removing trailing whitespace in markdown files will ruin line breaks.
To fix it the following settings needs to be added to the .editorconfig file:

[*.md]
trim_trailing_whitespace = false
CommentFileSizeAuthor
#25 drupal-2764829-25.patch1.48 KBfathershawn
#24 drupal-2764829-24.patch1.42 KBfathershawn
#21 drupal-2764829-21.patch1.46 KBjrockowitz
#13 2764829-editorconfig-markdown-d8-8-13.patch1.23 KBdaniel korte
#8 2764829-editorconfig-markdown-d8-8.patch252 bytesdaniel korte
#8 2764829-editorconfig-markdown-d7-8.patch276 bytesdaniel korte

Issue fork drupal-2764829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

FrittenKeeZ created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein commented
Issue tags: +Needs backport to D7

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Active » Needs review
StatusFileSize
new 2764829-editorconfig-markdown-d7-8.patch276 bytes
new 2764829-editorconfig-markdown-d8-8.patch252 bytes

Will some patches get this issue moving again? :)

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Version: 8.6.x-dev » 8.8.x-dev

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

malcomio’s picture

malcomio commented
Status: Needs review » Reviewed & tested by the community

This patch applies cleanly against both the 8.9.x and 9.1.x branches, and fixes the problem for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

We need to change gitattributes too then... I.e. I think that
*.md text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
needs to change to
*.md text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,-trailing-space,tabwidth=2
Otherwise using git to fix white issues will not work.

Also I didn't know about this use of trailing whitespace in markdown... very meh.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Needs work » Needs review
StatusFileSize
new 2764829-editorconfig-markdown-d8-8-13.patch1.23 KB

Updated!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

So I guess the one question is... are we really sure about this? Yes this is a feature of markdown. But other projects do not do this...
https://github.com/symfony/symfony/blob/5.x/.editorconfig

But some do...
https://github.com/laravel/laravel/blob/master/.editorconfig
https://github.com/facebook/react/blob/master/.editorconfig
https://github.com/vuejs/vue/blob/dev/.editorconfig

So okay it seems fine to do... fun. TIL markdown has significant whitespace at the end of a line... seems an interesting decision.

Status: Needs review » Needs work

The last submitted patch, 13: 2764829-editorconfig-markdown-d8-8-13.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Random unrelated JS fail

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new drupal-2764829-21.patch1.46 KB

Because of #3084326: Install .editorconfig and .gitattributes at the project root I think this patch needs to alter the files in /core/assets/scaffold/files.

The patch did not apply to my composer based installation.

Status: Needs review » Needs work

The last submitted patch, 21: drupal-2764829-21.patch, failed testing. View results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
StatusFileSize
new drupal-2764829-24.patch1.42 KB

Refactored the patch from #21 to the working directory chosen by composer.

Which also didn't apply with composer...

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
StatusFileSize
new drupal-2764829-25.patch1.48 KB

This patch applied via composer locally however

BennyBPB made their first commit to this issue’s fork.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.