Referencing new entity fails when reference method is view or entity is unpublished

I think the issue when you choose reference method views is resolved with this patch :
https://www.drupal.org/node/2800875

For the first one it looks like validation fails at:

/core/modules/node/src/Plugin/EntityReferenceSelection/NodeSelection.php

  public function validateReferenceableNewEntities(array $entities) {
    $entities = parent::validateReferenceableNewEntities($entities);
    // Mirror the conditions checked in buildEntityQuery().
    if (!$this->currentUser->hasPermission('bypass node access') && !count($this->moduleHandler->getImplementations('node_grants'))) {
      $entities = array_filter($entities, function ($node) {
        /** @var \Drupal\node\NodeInterface $node */
        return $node->isPublished();
      });
    }
    return $entities;
  }

So 2 options are to subclass NodeSelection and write a better validateReferenceableNewEntities()... or implement hook_node_grants so that count($this->moduleHandler->getImplementations('node_grants') !== 0.

The code from NodeSelection is exactly what was causing the issue, but this isn't a problem on the Drupal\Core\Entity\Element\EntityAutocomplete form element, just the inline_entity_form element. The difference is that EntityAutocomplete also calls the NodeSelection's createNewEntity() method, which sets the published state to True during form submission.

  /**
   * {@inheritdoc}
   */
  public function createNewEntity($entity_type_id, $bundle, $label, $uid) {
    $node = parent::createNewEntity($entity_type_id, $bundle, $label, $uid);

    // In order to create a referenceable node, it needs to published.
    /** @var \Drupal\node\NodeInterface $node */
    $node->setPublished(TRUE);

    return $node;
  }

IEF doesn't need to call the createNewEntity() function, though, because it creates the entity in another way. Besides, maybe we don't want to automatically publish every node people submit through IEF (thus disregarding the default published state).

I'm including a patch that works around this by adding a new property to the NodeInlineForm object "nodePublished". That property holds whether or not the inline node wanted to be published when the user hit "submit". Before validation, I setPublished to TRUE (same as NodeSelection does), then set it back to whatever "nodePublished" was before validation.

The patch from #6 doesn't work for me in the second case "when choosing reference method Views: Filter by an entity reference view" (referencing a custom entity).
However, this one fixed it: #2800875: Autocreate for Entity Reference selection handlers that extend ViewsSelection

The patch from #6 didn't work for me, using 8.x-1.0-beta1 and Drupal 8.4.

Anyway, found this module https://www.drupal.org/project/entity_reference_unpublished and with this patch was able to get in installed and it look ok https://www.drupal.org/node/2917012

Not sure if different issue.. but i have the same setup as original post; but in my case the Foo is not created (and neither is the Article).

I get the same error: This entity (node: New Place) cannot be referenced.

As the same user i try to create Foo directly; and this works fine.

I have applied the patch in #6 as well as enabled the entity_reference_unpublished module - no help.

if i set Foo to be published on creation - everything works as expected.

As a work around i added a Business Rule (Rules module sadly doesn't have an Unpublish action) to set any new Foo as unpublished; and then set Foo to publish on creation.

surprisingly, this worked.

I've updated the patch from #6 for compatibility with Drupal 9.5. It solves the first use case in the issue description.

The first case in this issue is caused by https://www.drupal.org/project/drupal/issues/2845144, I suspect.

The latest patch from that issue (67 right now) fixes the ability to reference new unpublished entities for me. The patch also improves the code that comment 5 from this issue said was at fault. (And certainly is where I've also traced the issue to myself).