Hi,

I installed and deinstalled the module and now I wanted to install it again, getting the above error message.

Best,
Tobias

CommentFileSizeAuthor
#47 interdiff.txt1.55 KBsam152
#47 2752167-test-47--fail.patch3.89 KBsam152
#47 2752167-test-47.patch3.27 KBsam152
#38 2752167-test-38--fail.patch3.22 KBsam152
#38 2752167-test-38.patch2.61 KBsam152
#38 interdiff.txt1.82 KBsam152
#26 interdiff.txt424 bytessam152
#26 2752167-test-26.patch2.52 KBsam152
#26 2752167-test-26--fail.patch3.12 KBsam152
#7 2752167-test-7.patch2.49 KBsam152
#7 2752167-test-7--fail.patch3.09 KBsam152
#6 2752167-test-6.patch2.56 KBsam152
#6 2752167-test-6--fail.patch3.16 KBsam152
#2 2752167-delete-image-style-config-on-uninstall-2.patch633 bytessam152
#2 Screen Shot 2016-06-20 at 9.18.17 PM.png116.92 KBsam152

Comments

tobiberlin created an issue. See original summary.

sam152’s picture

sam152 commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new Screen Shot 2016-06-20 at 9.18.17 PM.png116.92 KB
new 2752167-delete-image-style-config-on-uninstall-2.patch633 bytes

Thanks for the bug report. Adding the enforced_dependency ensures the object gets deleted when uninstalled:

sam152’s picture

sam152 commented
Status: Needs review » Fixed

  • Sam152 committed bbc9b36 on 8.x-1.x 
    Issue #2752167 by Sam152, tobiberlin: Unable to install Video Embed...
benjy’s picture

benjy commented

Could be worth a generic test that uninstalls and then re-installs the module, it would prevent other issues like this creeping in.

sam152’s picture

sam152 commented
Status: Fixed » Needs review
StatusFileSize
new 2752167-test-6--fail.patch3.16 KB
new 2752167-test-6.patch2.56 KB

Not a bad idea.

sam152’s picture

sam152 commented
StatusFileSize
new 2752167-test-7--fail.patch3.09 KB
new 2752167-test-7.patch2.49 KB

Without local testing trait.

The last submitted patch, 6: 2752167-test-6--fail.patch, failed testing.

The last submitted patch, 6: 2752167-test-6--fail.patch, failed testing.

The last submitted patch, 6: 2752167-test-6--fail.patch, failed testing.

The last submitted patch, 6: 2752167-test-6--fail.patch, failed testing.

The last submitted patch, 6: 2752167-test-6.patch, failed testing.

The last submitted patch, 6: 2752167-test-6.patch, failed testing.

The last submitted patch, 6: 2752167-test-6.patch, failed testing.

The last submitted patch, 6: 2752167-test-6.patch, failed testing.

The last submitted patch, 7: 2752167-test-7--fail.patch, failed testing.

The last submitted patch, 7: 2752167-test-7--fail.patch, failed testing.

The last submitted patch, 7: 2752167-test-7--fail.patch, failed testing.

The last submitted patch, 7: 2752167-test-7--fail.patch, failed testing.

benjy’s picture

benjy commented 
+++ b/tests/src/Functional/InstallationTest.php
@@ -0,0 +1,77 @@
+    if ($button = $this->getSession()->getPage()->findButton('Continue')) {
+      $button->press();
+    }

The test is non-deterministic?

Status: Needs review » Needs work

The last submitted patch, 7: 2752167-test-7.patch, failed testing.

The last submitted patch, 7: 2752167-test-7.patch, failed testing.

The last submitted patch, 7: 2752167-test-7.patch, failed testing.

The last submitted patch, 7: 2752167-test-7.patch, failed testing.

sam152’s picture

sam152 commented

Re: #20, On the second installation, the dependencies are already enabled, meaning there is no confirm step.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2752167-test-26--fail.patch3.12 KB
new 2752167-test-26.patch2.52 KB
new interdiff.txt424 bytes

The last submitted patch, 26: 2752167-test-26--fail.patch, failed testing.

The last submitted patch, 26: 2752167-test-26--fail.patch, failed testing.

The last submitted patch, 26: 2752167-test-26--fail.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 26: 2752167-test-26.patch, failed testing.

The last submitted patch, 26: 2752167-test-26.patch, failed testing.

The last submitted patch, 26: 2752167-test-26.patch, failed testing.

The last submitted patch, 26: 2752167-test-26.patch, failed testing.

The last submitted patch, 26: 2752167-test-26--fail.patch, failed testing.

sam152’s picture

sam152 commented

I forgot you can't enable modules from the UI with dependencies on specific versions. I ran into this on UpgradePathTest. The modules are cloned from git and thus don't have the packager "version" key in their info file, failing media entities installation dependent on entity (>=8.x-1.0-alpha3).

sam152’s picture

sam152 commented

The only way I can see to shim this in would be some kind of:

system_rebuild_module_data();
$data = &drupal_static('system_rebuild_module_data');
$data['entity']['version'] = '8.x-1.0-alpha3'

I'm pretty sure someone was looking into this as part of the composer stuff.

sam152’s picture

sam152 commented
Status: Needs work » Postponed

Postponed until the testbot includes versions in the checked out version of modules.

sam152’s picture

sam152 commented
Status: Postponed » Needs review
StatusFileSize
new interdiff.txt1.82 KB
new 2752167-test-38.patch2.61 KB
new 2752167-test-38--fail.patch3.22 KB

Perhaps exclude video_embed_media for now.

The last submitted patch, 38: 2752167-test-38.patch, failed testing.

The last submitted patch, 38: 2752167-test-38.patch, failed testing.

The last submitted patch, 38: 2752167-test-38.patch, failed testing.

The last submitted patch, 38: 2752167-test-38.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 38: 2752167-test-38--fail.patch, failed testing.

The last submitted patch, 38: 2752167-test-38--fail.patch, failed testing.

The last submitted patch, 38: 2752167-test-38--fail.patch, failed testing.

The last submitted patch, 38: 2752167-test-38--fail.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2752167-test-47.patch3.27 KB
new 2752167-test-47--fail.patch3.89 KB
new interdiff.txt1.55 KB

The last submitted patch, 47: 2752167-test-47.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 47: 2752167-test-47--fail.patch, failed testing.

The last submitted patch, 47: 2752167-test-47--fail.patch, failed testing.

The last submitted patch, 47: 2752167-test-47--fail.patch, failed testing.

The last submitted patch, 47: 2752167-test-47--fail.patch, failed testing.

sam152’s picture

sam152 commented
sam152’s picture

sam152 commented
Status: Needs work » Fixed

  • Sam152 committed 3b58131 on 8.x-1.x 
    Issue #2752167 by Sam152, benjy, tobiberlin: Unable to install Video...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.