[D7] Push Notifications Web

Don't place anybody in Assigned if you want your module reviewd

Automated Review

Issues reported by PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxdar2744895git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Remove all variables in a hook_uninstall()
2. (+) Does not necessery insert files[] with link to .module in .info

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Unable to verify the correct operation of the module because in free trial account Access denied (You are not authorized to access this page.) for page Sources

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hello,
I`ve reviewed your module, there are some issues:
1) Undefined variable + no spaces near concatenation dot http://storage6.static.itmages.com/i/16/0617/h_1466164877_7293839_03d2dc...
2) Codestyle http://storage1.static.itmages.com/i/16/0617/h_1466164949_6867693_b7ee2f...
http://storage4.static.itmages.com/i/16/0617/h_1466165000_3269952_4c42c9...
3) 3 similar functions which can be done as 1, also code style, unused variable
http://storage1.static.itmages.com/i/16/0617/h_1466165067_1364775_338afb...

Kind Regards.

Automated Review

Issues reported by PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxdar2744895git

Please check the automated review yourself before you change status

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi dar,

Please remove tab and align properly as per attached patch.

You still need to remove the "master" branch (as pointed out by the automatic review).

Great, fast and cheap idea. I have some trouble on initial setup but I think I'll use it for a lot of my sites!

Automated Review

Issues reported by PAReview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxdar2744895git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Remove all variables in a hook_uninstall()
2. Still i can see follwing variables which are not deleted on uninstall

 variable_get('push_notifications_web_UID', NULL);
 variable_get('push_notifications_web_API', NULL);
 variable_get('push_notifications_web_SOURCE', NULL);

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Unable to verify the correct operation of the module because in free trial account Access denied (You are not authorized to access this page.) for page Sources

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Automated Review
pareview.sh returned quite alot of issues, please try to fix them before opening the PA for review. Most of those directly violate Drupal Coding Standards. There is alot of unformatted, unindented code there. Try to use an IDE that can format all of your code. And those are the smallest issues.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Small sugestion here: Remove README.md if you don't intend to enter some content in it.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
(*) The code is not properly indented, it makes reading it so much harder.
(*) Using links in t() should be done by using placeholders. Some good examples here.
Given that there are so many coding standards issue, I didn't even dare to check what Coder module returns.
While drupal.org recommends code that comments itself, some usefull comments here and there would make the code alot more readable by others. Please keep in mind that this is an application to be able to post any number of full projects, not only this one.
Adding javascript to a page (or more) should be done using the #attached property instead of drupal_add_js. Read more here.
I don't think cache_clear_all() is meant to be in hook_uninstall.

If you fix theese issues, I can actually test the module and have a more in-depth look at the code. Thanks.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.