The backup_migrate_location_remote class has a few methods that are just code from backup_migrate_location duplicated verbatim. Obviously these can be removed.

CommentFileSizeAuthor
#2 backup_migrate-n2703351-2.patch1.63 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
backup_migrate-n2703351-2.patch1.63 KB

This removes backup_migrate_location_remote::url(), backup_migrate_location_remote::glue_url() and backup_migrate_location_remote::set_url().

ultrabob’s picture

ultrabob CreditAttribution: ultrabob commented

I read this patch, and confirmed that the backup_migrate_location_remote class extends backup_migrate_location but then declares those three identical methods. I installed the patch, and things seem to be working as normal. I don't actually have any remote databases set up though, I just have a secondary database also on localhost.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Parent issue: » #2912211: Plan for Backup and Migrate 7.x-3.4

Committed. Thanks for the review, ultrabob.

  • DamienMcKenna committed bd8c396 on 7.x-3.x 
    Issue #2703351 by DamienMcKenna, ultrabob: Redundant methods in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.