[D7] Field error message override

I will install and test it.
While you wait you could fix the code style issues ;-)
http://pareview.sh/pareview/httpgitdrupalorgsandboxsgurlt2685813git

Cheers

It is working.
But I was a bit confused what error message is replaced and it looks like it is only the required message.
I'm not even sure if there would be any other error messages. What happens if I enable this on a field with other validation like the file field or the email field?

If it is only replacing the required error maybe you should rename it to "Required Error Message" and move it next to the required checkbox. Maybe even hide it with state if required is not checked.

Other than that good idea.

Cheers
bechtold

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Good idea.

Would it be possible to move the settings to the field settings?
First of all I might want to use different settings on different fields on the same entity, I believe that is currently not possible.

Also I find the config page quite confusing (I have 13 entities with multiple bundles) and I didn't find it. I was instantly looking on the field settings and was wondering if the update didn't work.

Then I'm not sure if this way it is possible to integrate into a nice feature workflow. When I have one feature per entity, all the fields error settings should automatically be included into that feature. And I'm not sure if it is splittable at the moment anyways or if all the settings needed to go into one feature.

I still get quite a lot errors: http://pareview.sh/pareview/httpgitdrupalorgsandboxsgurlt2685813git

To get people to review your application, you need to set its state to "Needs review". Please see project applicaton workflow.

Adding clone url:

 git clone --branch 7.x-1.x https://git.drupal.org/sandbox/sgurlt/2685813.git field_error_message_override
cd field_error_message_override 

Automated Review

Please fix reported issue on https://pareview.sh/node/208

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[No: Does not follow] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) No Major finding, so marking it to RTBC
2. (+) No Release blocker

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Please fix issue reported on https://pareview.sh/node/208

Make sure delete all variables used in module under hook_uninstall();
Example :

variable_get($form['#entity_type'] . '_' . $form['#bundle'] . '_error_message_settings');

Minor coding standard errors and deleting variables are not application blockers. Anything else that you found or should this stay RTBC?

Hi Klausi,

I set it "Needs Works" as per point "Not deleting setting variables" on https://www.drupal.org/node/532400

Example review issues that warrant going back to Needs work

• Not using check_plain(), filter_xss() on user input that gets output to a page
• Not using database query placeholders
• Including third-party code
• Not deleting setting variables
• Sloppy formatting and disregard for Drupal formatting standards
• Naked hook_menu() items (ie, items without access checks)
• Untranslated strings

Is i am missing anything ? It will really help me for other project review.

Since the purpose of this queue is changed, I am not sure forgetting to delete a persistent variable is a blocker anymore.

Thank you for your contribution!

I will update your account so you can opt into security advisory coverage. See Goodbye Project Applications, Hello Security Advisory Opt-in to understand what that means, and what is different from the previous project application purpose.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Assigning credits.