Entity operations for menu links are hardcoded in edit menu form

Looks like this still needs to be done. And this is not a bug, changing to a task.

This should be NW

Rerolled against #2

Fixed custom command line against #19

Reroll the patch #20 with Drupal 9.5.x

Did try to review the patch, but not able to replicate the scenario correctly. Can someone provide testing steps here

I tried latest patch #22 which is completely wrong and untested. So next time @medha-kumari I suggest you test the patch before submitting. Going to hide patch from #22.

I tried patch #20, which did also not work on latest 9.5.x.
This seems to be related due to changes between older versions and 9.5.x.

Going to hide patch #19 also as they are re-rolled in #20

I'v re-rolled the patch #20 to 9.4.x/9.5.x and tested if its working like it should.

Steps to reproduce:

1. Install the module devel
2. Add a link to a menu
3. Visit the links overview for that menu
4. Open the contextual links
5. See that devel is NOT added

Steps to test:

1. Apply patch
2. Install the module devel
3. Add a link to a menu
4. Visit the links overview for that menu
5. Open the contextual links
6. See that devel is added

The scenario could be different depending on the use case.
For me the use case was that the Layout contextual link was not shown after installing Layout Builder Operation Link
Or you can add or alter contextual links yourself with hook_contextual_links_alter().

I don't have any Drupal 10 website running at the moment where I can test this and being short on time to set one up.
Also not really sure how to tackle this then. Should we create a patch for 10.x and port this to 9.x?
Anyone with more experience could shine a light?

Added patch against #26 in 10.1.x

Hi based on #27 i have Re-roll the patch and tested on Drupal 10.1.x
adding screenshot for the reference.
Kindly review patch
Thank you.

Adding a test case to validate the changes made in #26
Also, added test-only patch to replicate the scenarios.

@gaurav-mathur @Janvi Dasani:
We really don't need to re-roll the patch for 10.1.x since the patch for 9.5.x is cleanly applied on 10.1.x as well.
I suggest when you do the re-roll, please add a re-roll diff as well.
Here is the guide to generate the diff of re-roll.
That helps everyone to get more idea about the difference.

I am going to hide patch in #27 and #30 since those are incorrect reroll and not required. Feel free to enable display again if you see those are not applied correctly.

#32 Patch Applied on
10.1.x-dev and it fixes the issue.

#1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.) is doing something very similar.

getOperations() {
1. Should be typehinted as a new function

getResetRoute()
2. ditto

Typehint should be added for new functions in all spots.

Very nice work though!

Oh will need a change record also.

- Added type hints in the necessary methods.
- Added a change record here https://www.drupal.org/node/3338898 (first one from me 🎉)
Tests are passing on local.

Thank you!

Overall looks good, but a couple of nits:

1. +++ b/core/lib/Drupal/Core/Menu/MenuLinkBase.php
   @@ -160,6 +167,38 @@ public function getTranslateRoute() {
    
   +  public function getOperations(): array {
   +    $operations = [];
   +
   

   This is missing phpdoc.

2. +++ b/core/lib/Drupal/Core/Menu/MenuLinkInterface.php
   @@ -228,4 +238,16 @@ public function getEditRoute();
   +   */
   +  public function getOperations(): array;
   +
   

   OK it is because the interface method is added here. 1-1 rule so method addition is fine.

3. +++ b/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php
   @@ -185,23 +192,50 @@ public function getDescription() {
       */
      public function getTranslateRoute() {
   +    // TODO get link from ListBuilder values?
        return $this->getEntity()->toUrl('drupal:content-translation-overview');
      }
   

   Should this todo be resolved by this issue?

Addressed the comment #39 point 1
Keeping it in NW to address other point in #39
Attached patch against Drupal 10.1.x

- Attempting to fix the third suggestion in comment #39
Pulling translate link from operations.
I run all the test cases of `menu_link_content` module on local and those are still passing.

Moving back to Needs review since last failure was un-related and was from CkEditor5 module.
I triggered re-test and it is passing now.

Both of those look good!

I did some formatting and minor text changes to the Change record.

Committed f693212 and pushed to 10.1.x. Thanks!

There's a subtle API change here that broke a test in token module. Unlike the hardcoded logic before, the list builder checks access and doesn't return the edit route if the current user doesn't have access to it. The token tests didn't test this token with a logged in user, see #3360831: Fix test fail on Drupal 10.1.

I am leaving a comment for reference and awareness. During today's usability meeting #3420206: Drupal Usability Meeting 2024-02-16 we were discussing #3387665: Warn user when entity delete will cause menu item re-parenting. During the testing we've noticed the following issue i've created a followup issue for: #3421998: Menu links created by a view have a visually and functionally broken delete option. During the meeting we've tested on a install of Drupal 11.x. While writing up the followup I've tested on a install of Drupal 10.1.0 - the problem already existed there as well.