Replace deprecated usage of url() with Url::fromRoute

reference: https://www.drupal.org/node/2346779

CommentFileSizeAuthor
#5 password_reset_tabs.patch3.07 KBnikhilesh gupta
#4 patch_issue.png24.7 KBsaurabh.tripathi.cs
#2 2682495-2.patch3.05 KBxaiwant

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

xaiwant commented
Assigned: xaiwant » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2682495-2.patch3.05 KB

replaced deprecated url and applied latest patch

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented

Hi we are currently busy with other projects we will review this soon.
Thanks for the patch.

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Status: Needs review » Needs work
StatusFileSize
new patch_issue.png24.7 KB

@xaiwant ,
after applying this patch the url pointing to module UI stops working.Please check the snapshot.
Thanks.

nikhilesh gupta’s picture

nikhilesh gupta commented
StatusFileSize
new password_reset_tabs.patch3.07 KB

@saurabh.tripathi.cs

Try this patch

nikhilesh gupta’s picture

nikhilesh gupta commented
Status: Needs work » Needs review
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

@saurabh.tripathi.cs, #2 works fine.
Since Url::fromRoute('password_reset_tabs.provide_tabs')->toString() will return a GeneratedUrl/string which is similar in case of \Drupal::url('password_reset_tabs.provide_tabs')

And @Nikhilesh Gupta Url::fromRoute('password_reset_tabs.provide_tabs') is returning a Url object which is not a string.

nikhilesh gupta’s picture

nikhilesh gupta commented

With #2 links are not working it seems. I have seen one patch similar to this Deprecated Methods

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Status: Needs review » Needs work

Please Provide a valid patch in this as #2 is not working.

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Status: Needs work » Fixed
saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Status: Fixed » Closed (fixed)