Follow-up to #2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page:

"Permissions page" link in Admin > Appearance page breaks on a subdirectory setup of Drupal. The link points to the parent host and ignores the subdirectory !! Screenshot attached about the issue: http://i.imgur.com/ktsfzWE.png

CommentFileSizeAuthor
#18 Permission_link_on_drupal8.2.x.JPG129.58 KBTrupti Bhosale
#18 Permission_link_working_properly_on_drupal8.1.x.JPG128.94 KBTrupti Bhosale
#18 After_patch_Drupal_8.0.x.JPG134.61 KBTrupti Bhosale
#18 Patch_applied (1).JPG21.39 KBTrupti Bhosale
#18 Before_Patch_Drupal_8.0.x.JPG111.16 KBTrupti Bhosale
#17 permissions_page_link-2681753-17.patch839 bytesnesta_
#12 interdiff-2681753-10-12.txt1.02 KBlluvigne
#12 permissions_page_link-2681753-12.patch1.01 KBlluvigne
#10 permissions_page_link-2681753-10.patch1018 byteslluvigne
#10 interdiff-2681753-2-10.txt1 KBlluvigne
#2 drupal-fix_for_permissions_link-2681753-2-8.2.x.patch1016 bytessubharanjan

Comments

subharanjan created an issue. See original summary.

subharanjan’s picture

subharanjan commented
Status: Active » Needs review
StatusFileSize
new drupal-fix_for_permissions_link-2681753-2-8.2.x.patch1016 bytes
subharanjan’s picture

subharanjan commented
Issue summary: View changes
subharanjan’s picture

subharanjan commented
Issue summary: View changes
cilefen’s picture

cilefen commented
Title: "Permissions page" link in Admin > Appearance page breaks on subdirectory setup. » "Permissions page" link in Admin > Appearance is hardcoded and breaks on subdirectory setup.
Component: markup » node system
Issue tags: -subdirectory setup, -Permissions page
subharanjan’s picture

subharanjan commented
Assigned: subharanjan » Unassigned
cilefen’s picture

cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen commented
Status: Needs review » Needs work

url() is deprecated. Use Url::fromRoute() instead.

cilefen’s picture

cilefen commented
Issue tags: +Novice

A novice can handle the next step.

lluvigne’s picture

lluvigne
Primary language Spanish
Location Seville, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2681753-2-10.txt1 KB
new permissions_page_link-2681753-10.patch1018 bytes

Hi
in this patch i change the url() function to Url::fromRoute(), but for me doesn't work. Any idea?

Thanks

Status: Needs review » Needs work

The last submitted patch, 10: permissions_page_link-2681753-10.patch, failed testing.

lluvigne’s picture

lluvigne
Primary language Spanish
Location Seville, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new permissions_page_link-2681753-12.patch1.01 KB
new interdiff-2681753-10-12.txt1.02 KB

Sorry about my last patch, the url needs to be a string, not an object. Maybe this will work (manually tested, works fine).

Sorry and thanks.

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice

Good. Thank you!

  • catch committed 51372ae on 8.2.x 
    Issue #2681753 by lluvigne, subharanjan, cilefen: "Permissions page"...

  • catch committed b8d93bb on 8.1.x 
    Issue #2681753 by lluvigne, subharanjan, cilefen: "Permissions page"...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. The patch doesn't cherry-pick to 8.0.x so marking fixed, if you re-roll for 8.0.x before the last patch release, please reopen the issue.

nesta_’s picture

nesta_ commented
Status: Fixed » Needs review
StatusFileSize
new permissions_page_link-2681753-17.patch839 bytes

Backport to 8.0.x

Trupti Bhosale’s picture

Trupti Bhosale commented
StatusFileSize
new Before_Patch_Drupal_8.0.x.JPG111.16 KB
new Patch_applied (1).JPG21.39 KB
new After_patch_Drupal_8.0.x.JPG134.61 KB
new Permission_link_working_properly_on_drupal8.1.x.JPG128.94 KB
new Permission_link_on_drupal8.2.x.JPG129.58 KB

Verified the patch 'permissions_page_link-2681753-17.patch' in comment #17 on drupal 8.0.x site.Steps performed are as follows:
1.Installed Drupal site with branch 8.0.x
2.Navigated to Appearance page, Permission link was not displayed
3.Applied the patch 'permissions_page_link-2681753-17.patch'
4.Navigate to Appearance page, Permission link is displayed now and navigates to correct URL
Attached snapshot for reference.
Installed drupal 8.1.x and drupal8.2.x and observed that Permission link navigates to correct URL bydefault.

Trupti Bhosale’s picture

Trupti Bhosale commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Closed (fixed)
Related issues: +#2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page

We shouldn't backport this to to 8.0.x because the original patch that caused the issue was not - see #2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page.

In general we try not to add new translatable strings in patch releases.